Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753052AbbDFSp5 (ORCPT ); Mon, 6 Apr 2015 14:45:57 -0400 Received: from mail-gw3-out.broadcom.com ([216.31.210.64]:6156 "EHLO mail-gw3-out.broadcom.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752693AbbDFSpx (ORCPT ); Mon, 6 Apr 2015 14:45:53 -0400 X-IronPort-AV: E=Sophos;i="5.11,533,1422950400"; d="scan'208";a="61228212" Message-ID: <5522D2C7.8090708@broadcom.com> Date: Mon, 6 Apr 2015 11:39:03 -0700 From: Jonathan Richardson User-Agent: Mozilla/5.0 (X11; Linux i686; rv:17.0) Gecko/17.0 Thunderbird/17.0 MIME-Version: 1.0 To: Florian Fainelli CC: Andy Shevchenko , Mark Brown , Dmitry Torokhov , Anatol Pomazau , Scott Branden , Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , "Kumar Gala" , "linux-kernel@vger.kernel.org" , , bcm-kernel-feedback-list , devicetree , Rafal Milecki Subject: Re: [PATCH 3/4] spi: bcm-mspi: Make BCMA optional to support non-BCMA chips References: <1428002603-21892-1-git-send-email-jonathar@broadcom.com> <1428002603-21892-4-git-send-email-jonathar@broadcom.com> <551ED345.1000702@gmail.com> In-Reply-To: <551ED345.1000702@gmail.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2226 Lines: 53 On 15-04-03 10:52 AM, Florian Fainelli wrote: > On 03/04/15 06:38, Andy Shevchenko wrote: >> On Thu, Apr 2, 2015 at 10:23 PM, Jonathan Richardson >> wrote: >>> The Broadcom MSPI controller is used on various chips. The driver only >>> supported BCM53xx chips with BCMA (an AMBA bus variant). The driver is >>> refactored to make BCMA optional and provides a new config for non BCMA >>> systems. >> >>> struct bcm_mspi { >>> + #ifdef CONFIG_SPI_BCMA_MSPI >>> struct bcma_device *core; >>> - struct spi_master *master; >>> + #endif >>> >>> + void __iomem *base; >>> + struct spi_master *master; >>> size_t read_offset; >> >>> + void (*mspi_write)(struct bcm_mspi *mspi, u16 offset, u32 value); >>> + u32 (*mspi_read)(struct bcm_mspi *mspi, u16 offset); >>> +}; >> >> To avoid ugly ifdefs I think better to split driver to core part and >> the actual driver part, at the end you will have something like >> mspi-core.c mspi-53xx.c mspi-whatever.c. Check for example spi-dw*.c >> > > Actually, I am really curious whether we need the special BCMA I/O > accessors in the first place, cannot we just access the MSPI core on > BCM53xx chips using regular MMIO? That would probably solve the > "problem" entirely. Rafal, did you try this before? > > As for splitting the driver into a "library" driver which is mostly > independent from the bus and a bus-specific wrapper, I think BCMA is > really the only special case here, which is why I suggested earlier to > Jonathan that we might just prefer ifdefing things out instead of > creating a separate layer just for BCMA. > I cringed adding the ifdefs to the driver but didn't think the small amount of code that wouldn't be used again warranted 3 files. I could also handle the two different probe routines by doing some DT parsing in init, but then BCMA would have to be compiled for the non-BCMA MSPI driver and I didn't want to do that either. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/