Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753232AbbDFSnU (ORCPT ); Mon, 6 Apr 2015 14:43:20 -0400 Received: from seldrel01.sonyericsson.com ([212.209.106.2]:14065 "EHLO seldrel01.sonyericsson.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752687AbbDFSnT (ORCPT ); Mon, 6 Apr 2015 14:43:19 -0400 From: Bjorn Andersson To: Andy Whitcroft , Joe Perches CC: Subject: [PATCH] checkpatch: validate MODULE_LICENSE content Date: Mon, 6 Apr 2015 11:43:15 -0700 Message-ID: <1428345795-28255-1-git-send-email-bjorn.andersson@sonymobile.com> X-Mailer: git-send-email 1.8.2.2 MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1262 Lines: 43 There is a well defined list of expected values for MODULE_LICENSE so warn the user upon usage of unknown values. Signed-off-by: Bjorn Andersson --- scripts/checkpatch.pl | 16 ++++++++++++++++ 1 file changed, 16 insertions(+) diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl index d124359..7087b28 100755 --- a/scripts/checkpatch.pl +++ b/scripts/checkpatch.pl @@ -5354,6 +5354,22 @@ sub process { } } } + + if ($line =~ /MODULE_LICENSE\(($String)\)/) { + my $extracted_string = get_quoted_string($line, $rawline); + my $valid_licenses = qr{ + GPL| + GPL\ v2| + GPL\ and\ additional\ rights| + Dual\ BSD/GPL| + Dual\ MIT/GPL| + Dual\ MPL/GPL| + Proprietary + }x; + if ($extracted_string !~ /^"(?:$valid_licenses)"$/x) { + WARN("MODULE_LICENSE", "unknown module license " . $extracted_string . "\n" . $herecurr); + } + } } # If we have no input at all, then there is nothing to report on -- 1.8.2.2 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/