Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752825AbbDFW1e (ORCPT ); Mon, 6 Apr 2015 18:27:34 -0400 Received: from mail-qk0-f177.google.com ([209.85.220.177]:36469 "EHLO mail-qk0-f177.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751945AbbDFW1b (ORCPT ); Mon, 6 Apr 2015 18:27:31 -0400 MIME-Version: 1.0 In-Reply-To: <2916148.ZqFzHAuDtr@wuerfel> References: <1428356558-18367-1-git-send-email-abrestic@chromium.org> <1428356558-18367-2-git-send-email-abrestic@chromium.org> <2916148.ZqFzHAuDtr@wuerfel> Date: Mon, 6 Apr 2015 15:27:31 -0700 X-Google-Sender-Auth: KmGdS-6Zp-a4y7KgJxwoOnjAT2E Message-ID: Subject: Re: [PATCH V2 2/2] stmmac: Add IMG Pistachio platform glue layer From: Andrew Bresticker To: Arnd Bergmann , James Hartley Cc: "David S. Miller" , Giuseppe Cavallaro , "devicetree@vger.kernel.org" , netdev@vger.kernel.org, "linux-kernel@vger.kernel.org" , Govindraj Raja Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1235 Lines: 28 On Mon, Apr 6, 2015 at 3:10 PM, Arnd Bergmann wrote: > On Monday 06 April 2015 14:42:38 Andrew Bresticker wrote: >> At the moment, the only additional setup required for the DWMAC >> on the IMG Pistachio SoC is to request and enable a separate gate >> clock for the register interface. >> >> Signed-off-by: Andrew Bresticker >> Signed-off-by: Govindraj Raja >> Cc: James Hartley > > Why do you need a special glue driver for that? > > Since you don't do anything special, I'd say it should be possible > to handle this with just the default driver. Right, at the moment we only need to request and enable a second clock, which could be added to the core driver. If we don't expect to have to extend this driver to deal with other configurations (which IIRC there were some concerns about when I wrote this), then I'm fine with folding this change into the core driver - James? Thanks, Andrew -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/