Message-ID: <55230D74.3000003@biot.com>
Date: Tue, 07 Apr 2015 00:49:24 +0200
From: Bert Vermeulen <bert@biot.com>
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0
MIME-Version: 1.0
To: Andy Shevchenko <andy.shevchenko@gmail.com>
CC: Ralf Baechle <ralf@linux-mips.org>, Samuel Ortiz <sameo@linux.intel.com>,
        Lee Jones <lee.jones@linaro.org>, linux-mips@linux-mips.org,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] mfd: Add support for CPLD chip on Mikrotik RB4xx boards
References: <1428285076-14269-1-git-send-email-bert@biot.com> <CAHp75VfeY80hu9kZWJ1KPos7gzTgV53OT-X67MJWT2h8nGSjqw@mail.gmail.com>
In-Reply-To: <CAHp75VfeY80hu9kZWJ1KPos7gzTgV53OT-X67MJWT2h8nGSjqw@mail.gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1064
Lines: 34

Hi Andy,

I will submit a new version with your comments addressed. However this one:

On 04/06/2015 12:13 PM, Andy Shevchenko wrote:

>> +static struct spi_driver rb4xx_cpld_driver = {
>> +       .probe = rb4xx_cpld_probe,
>> +       .remove = rb4xx_cpld_remove,
>> +       .driver = {
>> +               .name = "rb4xx-cpld",
>> +               .bus = &spi_bus_type,
>> +               .owner = THIS_MODULE,
> 
> Do we really need this line?
>
> +       },
> +};
> +
> +module_spi_driver(rb4xx_cpld_driver);

Yes, apparently. It's only the module_platform_driver() macro that
automatically fills in the owner field. All SPI protocol drivers do this
(except one, video/backlight/hx8357.c). Having said that, I don't really get
what that field is used for.


-- 
Bert Vermeulen        bert@biot.com          email/xmpp
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/