Message-ID: <5523125E.2010605@amd.com>
Date: Mon, 6 Apr 2015 18:10:22 -0500
From: Aravind Gopalakrishnan <aravind.gopalakrishnan@amd.com>
User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0
MIME-Version: 1.0
To: Ingo Molnar <mingo@kernel.org>, Borislav Petkov <bp@suse.de>
CC: <tglx@linutronix.de>, <mingo@redhat.com>, <hpa@zytor.com>,
        <x86@kernel.org>, <bhelgaas@google.com>,
        <linux-kernel@vger.kernel.org>, <Suravee.Suthikulpanit@amd.com>,
        <joro@8bytes.org>
Subject: Re: [PATCH] x86, aperture: Check for GART before accessing GART registers
References: <1427898728-3434-1-git-send-email-Aravind.Gopalakrishnan@amd.com>
 <20150402100135.GA5210@gmail.com> <551D661D.3030000@amd.com>
 <20150402160634.GB8045@gmail.com> <551D6CF5.1010604@amd.com>
 <20150402165356.GE4579@pd.tnic> <551D7695.2010509@amd.com>
 <20150402171705.GF4579@pd.tnic> <20150402181903.GA8723@gmail.com>
In-Reply-To: <20150402181903.GA8723@gmail.com>
Content-Type: text/plain; charset="windows-1252"; format=flowed
Content-Transfer-Encoding: 7bit
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Apr 2015 23:10:25.6649
 (UTC)
X-MS-Exchange-CrossTenant-Id: fde4dada-be84-483f-92cc-e026cbee8e96
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=fde4dada-be84-483f-92cc-e026cbee8e96;Ip=[165.204.84.222];Helo=[atltwp02.amd.com]
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY1PR0201MB0885
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 1674
Lines: 46

On 4/2/2015 1:19 PM, Ingo Molnar wrote:

>
>> +	if (amd_gart_present())
>>   		amd_northbridges.flags |= AMD_NB_GART;
>>   
>>   	/*
>> diff --git a/arch/x86/kernel/aperture_64.c b/arch/x86/kernel/aperture_64.c
>> index 76164e173a24..1cb170b06853 100644
>> --- a/arch/x86/kernel/aperture_64.c
>> +++ b/arch/x86/kernel/aperture_64.c
>> @@ -262,7 +262,7 @@ void __init early_gart_iommu_check(void)
>>   	u64 aper_base = 0, last_aper_base = 0;
>>   	int aper_enabled = 0, last_aper_enabled = 0, last_valid = 0;
>>   
>> -	if (!early_pci_allowed())
>> +	if (!early_pci_allowed() || !amd_gart_present())
>>   		return;
>>   
>>   	/* This is mostly duplicate of iommu_hole_init */
>> @@ -356,7 +356,7 @@ int __init gart_iommu_hole_init(void)
>>   	int i, node;
>>   
>>   	if (gart_iommu_aperture_disabled || !fix_aperture ||
>> -	    !early_pci_allowed())
>> +	    !early_pci_allowed() || !amd_gart_present())
>>   		return -ENODEV;
> So what happens if !early_pci_allowed() but the GART is present? We'll
> set amd_northbridges.flags |= AMD_NB_GART, but won't run any of the
> setup code in aperture_64.c, right? Is that a valid setup?
>

It might be a valid setup. But it would work correctly only if BIOS did 
the right thing with setting up aperture space.

If !early_pci_allowed() and BIOS did not setup aperture correctly, that 
would have caused problems already.
But it has not been an issue so far right?

Thanks,
-Aravind.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/