Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753055AbbDGCGI (ORCPT ); Mon, 6 Apr 2015 22:06:08 -0400 Received: from szxga02-in.huawei.com ([119.145.14.65]:20416 "EHLO szxga02-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752687AbbDGCGG (ORCPT ); Mon, 6 Apr 2015 22:06:06 -0400 Message-ID: <55233B79.1050706@huawei.com> Date: Tue, 7 Apr 2015 10:05:45 +0800 From: leizhen User-Agent: Mozilla/5.0 (Windows NT 6.1; rv:17.0) Gecko/20130801 Thunderbird/17.0.8 MIME-Version: 1.0 To: Jason Cooper CC: Thomas Gleixner , Marc Zyngier , linux-kernel , Zefan Li , Xinwei Hu , Tianhong Ding , Kefeng Wang , Yun Wu Subject: Re: [PATCH 1/1] irqchip/gicv3-its: remove GITS_BASER_TYPE_CPU base on latest specification References: <1428032032-11128-1-git-send-email-thunder.leizhen@huawei.com> <20150403144624.GM24598@io.lakedaemon.net> In-Reply-To: <20150403144624.GM24598@io.lakedaemon.net> Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.177.27.142] X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2588 Lines: 74 On 2015/4/3 22:46, Jason Cooper wrote: > Zhen Lei, > > On Fri, Apr 03, 2015 at 11:33:52AM +0800, Zhen Lei wrote: >> Acutally, "Interrupt Collections" and "Physical Processors" is the >> same thing. > > I'm sorry, but this isn't clear. > >> Signed-off-by: Zhen Lei >> --- >> drivers/irqchip/irq-gic-v3-its.c | 2 +- >> include/linux/irqchip/arm-gic-v3.h | 2 +- >> 2 files changed, 2 insertions(+), 2 deletions(-) >> >> diff --git a/drivers/irqchip/irq-gic-v3-its.c b/drivers/irqchip/irq-gic-v3-its.c >> index 9687f8a..a795aae 100644 >> --- a/drivers/irqchip/irq-gic-v3-its.c >> +++ b/drivers/irqchip/irq-gic-v3-its.c >> @@ -777,7 +777,7 @@ static int __init its_alloc_lpi_tables(void) >> static const char *its_base_type_string[] = { >> [GITS_BASER_TYPE_DEVICE] = "Devices", >> [GITS_BASER_TYPE_VCPU] = "Virtual CPUs", >> - [GITS_BASER_TYPE_CPU] = "Physical CPUs", >> + [GITS_BASER_TYPE_RESERVED3] = "Reserved (3)", > > Are you fixing a bug? Was the old information wrong? Did the spec get > revised? In spec version 19.0, clause 5.12.13 GITS_BASERn. The "Type" field define value=0x3 means: 0x3. Physical Processors. This register corresponds to a table that scales according to the number of physical processors in the system and requires (Entry-size * number-of-processors) bytes of memory. In spec version 24.0, clause 5.12.13 GITS_BASERn. The "Type" field define value=0x3 as reserved: 0x3. Reserved. > > Please redo your commit message to explain why this change is necessary and > what it's doing. OK, thank you for your advise. > >> [GITS_BASER_TYPE_COLLECTION] = "Interrupt Collections", >> [GITS_BASER_TYPE_RESERVED5] = "Reserved (5)", >> [GITS_BASER_TYPE_RESERVED6] = "Reserved (6)", >> diff --git a/include/linux/irqchip/arm-gic-v3.h b/include/linux/irqchip/arm-gic-v3.h >> index ffbc034..67f5779 100644 >> --- a/include/linux/irqchip/arm-gic-v3.h >> +++ b/include/linux/irqchip/arm-gic-v3.h >> @@ -233,7 +233,7 @@ >> #define GITS_BASER_TYPE_NONE 0 >> #define GITS_BASER_TYPE_DEVICE 1 >> #define GITS_BASER_TYPE_VCPU 2 >> -#define GITS_BASER_TYPE_CPU 3 >> +#define GITS_BASER_TYPE_RESERVED3 3 >> #define GITS_BASER_TYPE_COLLECTION 4 >> #define GITS_BASER_TYPE_RESERVED5 5 >> #define GITS_BASER_TYPE_RESERVED6 6 >> -- >> 1.8.0 > > thx, > > Jason. > > . > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/