Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753193AbbDGDno (ORCPT ); Mon, 6 Apr 2015 23:43:44 -0400 Received: from mail-qk0-f179.google.com ([209.85.220.179]:34570 "EHLO mail-qk0-f179.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753027AbbDGDnl (ORCPT ); Mon, 6 Apr 2015 23:43:41 -0400 MIME-Version: 1.0 In-Reply-To: References: <1427857069-6789-1-git-send-email-yinghai@kernel.org> <1427857069-6789-4-git-send-email-yinghai@kernel.org> <20150406220638.GH10892@google.com> <20150406224913.GI10892@google.com> From: Bjorn Helgaas Date: Mon, 6 Apr 2015 22:43:20 -0500 Message-ID: Subject: Re: [PATCH 3/3] PCI: Set pref for mem64 resource of pcie device To: Yinghai Lu Cc: David Miller , David Ahern , "linux-pci@vger.kernel.org" , "sparclinux@vger.kernel.org" , Linux Kernel Mailing List , "stable@vger.kernel.org" Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1858 Lines: 40 On Mon, Apr 6, 2015 at 8:13 PM, Yinghai Lu wrote: > On Mon, Apr 6, 2015 at 3:49 PM, Bjorn Helgaas wrote: >> >> For "[PATCH 1/3] PCI: Introduce pci_bus_addr_t", I'm waiting for an updated >> version with Kconfig tweaks so we don't break other arches. > > I was thinking that you will update it manually. I asked you for an updated version, incorporating the documentation updates, to make sure I got everything you intended. But I did go ahead and do it manually for you. >> For "[PATCH 2/3] sparc/PCI: Add mem64 resource parsing for root bus", I'm >> waiting for a version that fixes the other of_bus_pci_get_flags() and >> pci_parse_of_flags() implementations at the same time (or an explanation >> about why we should fix only the arch/sparc version). I don't want to fix >> one place and leave the same bug in other places. > > I don't even know if other arch like powerpc support 64-bit bus address. > > No one from powerpc reported a problem, why should we mess it up now? > > I would like to see someone get access those three kinds of machine that support > of to unify of support code. Of course changes there should be tested on all the affected machines. I opened https://bugzilla.kernel.org/show_bug.cgi?id=96241 and assigned it to you as a reminder that there is nearly identical code in several other places that may have the same issue. I pushed these two changes to for-linus. I'll work on the third tomorrow. The current changelog is very sparc64-centric, and it needs to be much more explicit about how the change will affect every arch. Bjorn -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/