Message-ID: <1428378769.20888.12.camel@perches.com>
Subject: Re: [PATCH 1/1] checkpatch: improve operator spacing check
From: Joe Perches <joe@perches.com>
To: Sam Bobroff <sam.bobroff@au1.ibm.com>,
        Andrew Morton <akpm@linux-foundation.org>
Cc: linux-kernel@vger.kernel.org, apw@canonical.com
Date: Mon, 06 Apr 2015 20:52:49 -0700
In-Reply-To: <203326aa74b4de17ebbc27acfde0790f5ec48504.1428377753.git.sam.bobroff@au1.ibm.com>
References: <203326aa74b4de17ebbc27acfde0790f5ec48504.1428377753.git.sam.bobroff@au1.ibm.com>
Content-Type: text/plain; charset="ISO-8859-1"
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1240
Lines: 40

On Tue, 2015-04-07 at 13:36 +1000, Sam Bobroff wrote:
> Code such as:
>        x = timercmp(&now, &end, <);
> Will currently trigger a checkpatch error. e.g.
> ERROR: spaces required around that '<'
> 
> This is because the "Ignore operators passed as parameters" check
> looks only for a comma following the operator. Improve the check by
> also looking for a close parenthesis.
> 
> Signed-off-by: Sam Bobroff <sam.bobroff@au1.ibm.com>

Seems sensible, thanks.

> ---
> 
>  scripts/checkpatch.pl |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
> index d124359..f65c4de 100755
> --- a/scripts/checkpatch.pl
> +++ b/scripts/checkpatch.pl
> @@ -3565,7 +3565,7 @@ sub process {
>  
>  				# Ignore operators passed as parameters.
>  				if ($op_type ne 'V' &&
> -				    $ca =~ /\s$/ && $cc =~ /^\s*,/) {
> +				    $ca =~ /\s$/ && $cc =~ /^\s*[,\)]/) {
>  
>  #				# Ignore comments
>  #				} elsif ($op =~ /^$;+$/) {


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/