Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753026AbbDGHcf (ORCPT ); Tue, 7 Apr 2015 03:32:35 -0400 Received: from mail-ob0-f181.google.com ([209.85.214.181]:34151 "EHLO mail-ob0-f181.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752919AbbDGHce (ORCPT ); Tue, 7 Apr 2015 03:32:34 -0400 MIME-Version: 1.0 In-Reply-To: <20150406193509.GA4476@rhlx01.hs-esslingen.de> References: <1428311077-32198-1-git-send-email-kuleshovmail@gmail.com> <20150406193509.GA4476@rhlx01.hs-esslingen.de> Date: Tue, 7 Apr 2015 13:32:33 +0600 Message-ID: Subject: Re: [PATCH] x86/boot: use __noreturn instead of directly __attribute__ definition From: Alexander Kuleshov To: Andreas Mohr Cc: Ingo Molnar , Thomas Gleixner , "H. Peter Anvin" , LKML Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 749 Lines: 22 Hello Andreas, > > IMHO explicitly #include:ing parts > which certain code does actively depend on after all > is both a "code honesty" > and a documentation issue ("Hmm, which interfaces does this implementation > depend on? Ah, yeah...") > Yes, before the patch i was in hesitancy, how to be with 'includes'. To add linux/compiler.h to the boot.h or do not do it as it already in the bitops.h. That's why I have added note about in to the commit message, for getting feedback about this. Thank you. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/