MIME-Version: 1.0
In-Reply-To: <5522D0BA.2050805@broadcom.com>
References: <1428002603-21892-1-git-send-email-jonathar@broadcom.com>
	<1428002603-21892-3-git-send-email-jonathar@broadcom.com>
	<CAHp75Vf0JrB5pqNEouLzyOf5mmi05Ut_cybd37suTrLbJOFHKA@mail.gmail.com>
	<5522D0BA.2050805@broadcom.com>
Date: Tue, 7 Apr 2015 11:03:09 +0300
Message-ID: <CAHp75Vf3Fyw-ZgcgsCki6_TvqMh9A3+dmeRLq42pcTj7YAieQQ@mail.gmail.com>
Subject: Re: [PATCH 2/4] spi: bcm53xx: Refactor to make driver nonspecific to
 53xx SoCs
From: Andy Shevchenko <andy.shevchenko@gmail.com>
To: Jonathan Richardson <jonathar@broadcom.com>
Cc: Mark Brown <broonie@kernel.org>, Dmitry Torokhov <dtor@google.com>,
        Anatol Pomazau <anatol@google.com>,
        Scott Branden <sbranden@broadcom.com>,
        Rob Herring <robh+dt@kernel.org>, Pawel Moll <pawel.moll@arm.com>,
        Mark Rutland <mark.rutland@arm.com>,
        Ian Campbell <ijc+devicetree@hellion.org.uk>,
        Kumar Gala <galak@codeaurora.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        linux-spi@vger.kernel.org,
        bcm-kernel-feedback-list <bcm-kernel-feedback-list@broadcom.com>,
        devicetree <devicetree@vger.kernel.org>,
        Rafal Milecki <zajec5@gmail.com>
Content-Type: text/plain; charset=UTF-8
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1114
Lines: 31

On Mon, Apr 6, 2015 at 9:30 PM, Jonathan Richardson
<jonathar@broadcom.com> wrote:
> On 15-04-03 06:35 AM, Andy Shevchenko wrote:
>> On Thu, Apr 2, 2015 at 10:23 PM, Jonathan Richardson
>> <jonathar@broadcom.com> wrote:
>>> The Broadcom MSPI controller is used on various SoCs. It is being
>>> renamed so that it can be extended and reused on other chips. It is
>>> renamed to bcm-mspi.
>>>
>> What if you resend this one with -M -C applied?
>>
>>
>
> I'm not seeing any difference in the patches unfortunately. I'll keep
> playing with it and re-send if I can find a way to improve it.
>
> The changes are just renaming variables, structures, functions, file
> name to get rid of 53xx and replace with mspi. The config is renamed
> from SPI_BCM53XX to SPI_BCMA_MSPI.
>

Better to split: a) moving, b) renaming something inside.

-- 
With Best Regards,
Andy Shevchenko
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/