Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753114AbbDGIIT (ORCPT ); Tue, 7 Apr 2015 04:08:19 -0400 Received: from pegase1.c-s.fr ([93.17.236.30]:52884 "EHLO mailhub1.si.c-s.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751410AbbDGIIN (ORCPT ); Tue, 7 Apr 2015 04:08:13 -0400 Message-ID: <5523905E.6050007@c-s.fr> Date: Tue, 07 Apr 2015 10:07:58 +0200 From: leroy christophe User-Agent: Mozilla/5.0 (Windows NT 5.1; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 MIME-Version: 1.0 To: Scott Wood CC: Benjamin Herrenschmidt , Paul Mackerras , Michael Ellerman , linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org Subject: Re: powerpc32: fix warning from include/linux/mm.h References: <20141205112020.640FA1A5D4F@localhost.localdomain> <20150320235213.GA1233@home.buserror.net> In-Reply-To: <20150320235213.GA1233@home.buserror.net> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1277 Lines: 31 Le 21/03/2015 00:52, Scott Wood a ?crit : > On Fri, Dec 05, 2014 at 12:20:20PM +0100, LEROY Christophe wrote: >> include/linux/mm.h: In function 'is_vmalloc_addr': >> include/linux/mm.h:367:14: warning: comparison between signed and unsigned integer expressions [-Wsign-compare] >> return addr >= VMALLOC_START && addr < VMALLOC_END; >> ^ >> >> Signed-off-by: Christophe Leroy >> --- >> arch/powerpc/include/asm/pgtable-ppc32.h | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) > That warning doesn't appear to be enabled. What config are you seeing > this with? I'm used to adding EXTRA_CFLAGS=-Wextra when checking my own drivers, as it helps finding additional bugs. When doing that, the only warnings I get outside of my own code are this one, and the other one in my proposed patch identified "powerpc32: fix warning from include/asm-generic/termios-base.h" I though it would be worth fixing those two warnings in order to get a perfectly clean code. Christophe -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/