Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753612AbbDGJtA (ORCPT ); Tue, 7 Apr 2015 05:49:00 -0400 Received: from bhuna.collabora.co.uk ([93.93.135.160]:53413 "EHLO bhuna.collabora.co.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753588AbbDGJsx (ORCPT ); Tue, 7 Apr 2015 05:48:53 -0400 Message-ID: <5523A7FF.2030700@collabora.co.uk> Date: Tue, 07 Apr 2015 11:48:47 +0200 From: Javier Martinez Canillas User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Icedove/31.2.0 MIME-Version: 1.0 To: Krzysztof Kozlowski , Andrzej Hajda , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org, Kukjin Kim CC: Marek Szyprowski Subject: Re: [PATCH v2 1/2] ARM: EXYNOS: Get current parent clock for power domain on/off References: <1428053635-10855-1-git-send-email-k.kozlowski@samsung.com> In-Reply-To: <1428053635-10855-1-git-send-email-k.kozlowski@samsung.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1174 Lines: 35 Hello Krzysztof, On 04/03/2015 11:33 AM, Krzysztof Kozlowski wrote: > Using a fixed (by DTS) parent for clocks when turning on the power domain > may introduce issues in other drivers. For example when such driver > changes the parent during runtime and expects that he is the only place > of such change. > > Do not rely on DTS providing the fixed parent for such clocks. Instead > before switching domain off, grab a current parent of a clock with > clk_get_parent(). > > Signed-off-by: Krzysztof Kozlowski > > --- > > Changes since v1: > 1. Drop "pclk" bindings entirely as suggested by Andrzej Hajda. > This was significant change so I did not add Javier's > reviewed/tested tags. Reviewed-by: Javier Martinez Canillas on an Exynos5420 Peach Pit Chromebook: Tested-by: Javier Martinez Canillas Best regards, Javier -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/