Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752620AbbDGKTF (ORCPT ); Tue, 7 Apr 2015 06:19:05 -0400 Received: from mail-ob0-f178.google.com ([209.85.214.178]:35225 "EHLO mail-ob0-f178.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750943AbbDGKTA (ORCPT ); Tue, 7 Apr 2015 06:19:00 -0400 MIME-Version: 1.0 In-Reply-To: <20150407095228.GA13093@gmail.com> References: <1428326234-10067-1-git-send-email-kuleshovmail@gmail.com> <20150407095228.GA13093@gmail.com> Date: Tue, 7 Apr 2015 16:19:00 +0600 Message-ID: Subject: Re: [PATCH] x86/earlyprintk: setup earlyprintk as early as possible From: Alexander Kuleshov To: Ingo Molnar Cc: Thomas Gleixner , Ingo Molnar , "H. Peter Anvin" , Greg Kroah-Hartman , LKML Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1220 Lines: 23 2015-04-07 15:52 GMT+06:00 Ingo Molnar : > > It would be nice to test it via a well placed printk() and check that > before the patch the message doesn't go to the serial console and > after the patch the message indeed arrives on the early serial console > - or something like that. I have tested this patch when i wrote it and early_printk does not print anything before the parse_early_param. But i don't know how to show this in code in a correct way. Maybe we should to give back early_printk call which i removed in the previous patch (https://git.kernel.org/cgit/linux/kernel/git/next/linux-next.git/commit/?id=91d8f0416f3989e248d3a3d3efb821eda10a85d2)? Any one another question about this. I submited patch only for head64.c and it does not affect kernel for i386, because i'm not sure where is the best place to setup earlyprintk in the head32.c. I thought to put it in the start of i386_start_kernel(void) (from head32.c) but not sure about it. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/