Message-ID: <5523B4AE.40606@intel.com>
Date: Tue, 07 Apr 2015 13:42:54 +0300
From: Adrian Hunter <adrian.hunter@intel.com>
Organization: Intel Finland Oy, Registered Address: PL 281, 00181 Helsinki,
 Business Identity Code: 0357606 - 4, Domiciled in Helsinki 
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0
MIME-Version: 1.0
To: Jiri Olsa <jolsa@redhat.com>, Wang Nan <wangnan0@huawei.com>
CC: namhyung@kernel.org, jolsa@kernel.org, acme@redhat.com, mingo@kernel.org,
        linux-kernel@vger.kernel.org, pi3orama@163.com
Subject: Re: [PATCH] perf: kmaps: enforce usage of kmaps to protect futher
 bugs.
References: <20150403064822.GB29383@gmail.com> <1428050877-54093-1-git-send-email-wangnan0@huawei.com> <20150403111146.GC5571@krava.brq.redhat.com>
In-Reply-To: <20150403111146.GC5571@krava.brq.redhat.com>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 749
Lines: 19

On 03/04/15 14:11, Jiri Olsa wrote:
> On Fri, Apr 03, 2015 at 08:47:57AM +0000, Wang Nan wrote:
>> This patch add checkings on every place where uses map__kmap and get
>> kmaps from struct kmap. Error messages are added at map__kmap to warn
>> invalud accessing of kmap (for the case of !map->dso->kernel, kmap(map)
>> is not exists at all). Also, introduces map__kmaps() to warn
>> uninitialized kmaps.
> 
> looks ok, CC-ing Adrian

Look Ok to me too

Acked-by: Adrian Hunter <adrian.hunter@intel.com>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/