Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753414AbbDGLRs (ORCPT ); Tue, 7 Apr 2015 07:17:48 -0400 Received: from mezzanine.sirena.org.uk ([106.187.55.193]:54130 "EHLO mezzanine.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752479AbbDGLRn (ORCPT ); Tue, 7 Apr 2015 07:17:43 -0400 Date: Tue, 7 Apr 2015 12:17:38 +0100 From: Mark Brown To: Andrew Bresticker Cc: linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org, Ezequiel Garcia Message-ID: <20150407111738.GI6023@sirena.org.uk> References: <1428355747-16822-1-git-send-email-abrestic@chromium.org> <1428355747-16822-3-git-send-email-abrestic@chromium.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="AqQmwD3r69meD/Zp" Content-Disposition: inline In-Reply-To: <1428355747-16822-3-git-send-email-abrestic@chromium.org> X-Cookie: I've been there. User-Agent: Mutt/1.5.23 (2014-03-12) X-SA-Exim-Connect-IP: 94.175.94.161 X-SA-Exim-Mail-From: broonie@sirena.org.uk Subject: Re: [PATCH 3/5] spi: img-spfi: Implement an unprepare_message() callback X-SA-Exim-Version: 4.2.1 (built Mon, 26 Dec 2011 16:24:06 +0000) X-SA-Exim-Scanned: Yes (on mezzanine.sirena.org.uk) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1271 Lines: 35 --AqQmwD3r69meD/Zp Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Mon, Apr 06, 2015 at 02:29:05PM -0700, Andrew Bresticker wrote: > The driver can be greatly simplified by moving the transfer > finishing and timeout handling to an unprepare_message() callback. The timeout handling would actually be better moved to the handle_err() callback which is provided for that purpose. --AqQmwD3r69meD/Zp Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBCAAGBQJVI7zRAAoJECTWi3JdVIfQFkYH/R/uZtY6y2kqsiPccdEadhoK +9OLr5vJWMj9q0Ecfdwggofkz7OmMhs9KRVbZ2cB41NVs2R6Uy90/yW7MsU+QTuJ IzTaD3Yu3C8lV/B0jX+MpsGCFH0TCpK+5p7HYgBD1uM5kIugmtvswhj5OAN37by9 94HyVnB9qnrNZKS5RPw/qFSnRjWqPWSEfsZdBAiEP9Od5/EuLjI2pe1/ZsAOEfrv JI39DRNDzAwkyjAdi4uoMuWa6aOXKUD7haQAL/+XSMIcNEE+t797wAAaqAKrzju+ TpYLiAyxBPjOwU1pzWVAP3Xw6UY38MjU8yasv3SXYPrhu8GtSFlyE1c/Npwtpws= =aDYK -----END PGP SIGNATURE----- --AqQmwD3r69meD/Zp-- -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/