Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753210AbbDGMDn (ORCPT ); Tue, 7 Apr 2015 08:03:43 -0400 Received: from mail-bn1bon0139.outbound.protection.outlook.com ([157.56.111.139]:50391 "EHLO na01-bn1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751267AbbDGMDj (ORCPT ); Tue, 7 Apr 2015 08:03:39 -0400 Authentication-Results: spf=fail (sender IP is 192.88.168.50) smtp.mailfrom=freescale.com; freescale.mail.onmicrosoft.com; dkim=none (message not signed) header.d=none; From: Ramneek Mehresh To: , CC: , , , Ramneek Mehresh Subject: [PATCH 8/9] usb:fsl:otg: Resolve OTG crash issue with another host Date: Tue, 7 Apr 2015 17:28:38 +0530 Message-ID: <1428407919-24655-8-git-send-email-ramneek.mehresh@freescale.com> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: <1428407919-24655-1-git-send-email-ramneek.mehresh@freescale.com> References: <1428407919-24655-1-git-send-email-ramneek.mehresh@freescale.com> X-EOPAttributedMessage: 0 X-Forefront-Antispam-Report: CIP:192.88.168.50;CTRY:US;IPV:NLI;EFV:NLI;BMV:1;SFV:NSPM;SFS:(10019020)(6009001)(339900001)(199003)(189002)(105606002)(92566002)(76506005)(47776003)(106466001)(33646002)(229853001)(36756003)(77156002)(46102003)(62966003)(6806004)(85426001)(50466002)(48376002)(86362001)(87936001)(2950100001)(104016003)(50226001)(50986999)(19580405001)(19580395003)(77096005)(76176999);DIR:OUT;SFP:1102;SCL:1;SRVR:BY2PR03MB173;H:tx30smr01.am.freescale.net;FPR:;SPF:Fail;MLV:sfv;A:1;MX:1;LANG:en; MIME-Version: 1.0 Content-Type: text/plain X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:BY2PR03MB173;UriScan:;BCL:0;PCL:0;RULEID:;SRVR:BY2PR03MB025; X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004)(5005006)(5002010);SRVR:BY2PR03MB173;BCL:0;PCL:0;RULEID:;SRVR:BY2PR03MB173; X-Forefront-PRVS: 0539EEBD11 X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Apr 2015 11:48:44.7867 (UTC) X-MS-Exchange-CrossTenant-Id: 710a03f5-10f6-4d38-9ff4-a80b81da590d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=710a03f5-10f6-4d38-9ff4-a80b81da590d;Ip=[192.88.168.50];Helo=[tx30smr01.am.freescale.net] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY2PR03MB173 X-OriginatorOrg: freescale.com Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1132 Lines: 34 Resolves kernel crash issue when a USB flash drive is inserted into USB1 port with USB2 port configured as otg. Removing "else" block so that the controller coming up in "non-otg" mode doesn't return -ENODEV. Returning "ENODEV" results in platform framework unbinding platform-drv from controller resulting in kernel crash later in hub driver Signed-off-by: Ramneek Mehresh --- drivers/usb/host/ehci-fsl.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/usb/host/ehci-fsl.c b/drivers/usb/host/ehci-fsl.c index 76dfc84..fe40d89 100644 --- a/drivers/usb/host/ehci-fsl.c +++ b/drivers/usb/host/ehci-fsl.c @@ -204,9 +204,6 @@ static int usb_hcd_fsl_probe(const struct hc_driver *driver, } ehci_fsl->have_hcd = 1; - } else { - dev_err(&pdev->dev, "wrong operating mode\n"); - return -ENODEV; } #endif return retval; -- 1.8.3.1 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/