Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753045AbbDGMHp (ORCPT ); Tue, 7 Apr 2015 08:07:45 -0400 Received: from bombadil.infradead.org ([198.137.202.9]:43258 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752518AbbDGMHn (ORCPT ); Tue, 7 Apr 2015 08:07:43 -0400 Date: Tue, 7 Apr 2015 14:07:30 +0200 From: Peter Zijlstra To: Mike Galbraith Cc: Thomas Gleixner , Thavatchai Makphaibulchoke , Steven Rostedt , LKML , mingo@redhat.com, linux-rt-users Subject: Re: [PATCH v2 1/2] rtmutex Real-Time Linux: Fixing kernel BUG at kernel/locking/rtmutex.c:997! Message-ID: <20150407120730.GQ24151@twins.programming.kicks-ass.net> References: <1424395866-81589-1-git-send-email-tmac@hp.com> <1428369962-74723-1-git-send-email-tmac@hp.com> <1428369962-74723-2-git-send-email-tmac@hp.com> <1428407236.3152.81.camel@gmail.com> <20150407120403.GN21418@twins.programming.kicks-ass.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150407120403.GN21418@twins.programming.kicks-ass.net> User-Agent: Mutt/1.5.21 (2012-12-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 624 Lines: 16 On Tue, Apr 07, 2015 at 02:04:03PM +0200, Peter Zijlstra wrote: > +out: > +#ifdef CONFIG_PREEMPT_RT_FULL > + rt_spin_unlock_after_trylock_in_irq(&base->lock); > +#endif > + /* The ; ensures that gcc won't complain in the !RT case */ > + ; > } Fwiw, I typically use a 'return' in that case. But yes, gcc is a bit of a whiny arse when it comes to labels to the end of the block. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/