Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1754453AbbDGN4l (ORCPT <rfc822;w@1wt.eu>);
	Tue, 7 Apr 2015 09:56:41 -0400
Received: from smtprelay0160.hostedemail.com ([216.40.44.160]:44473 "EHLO
	smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL)
	by vger.kernel.org with ESMTP id S1753684AbbDGN4i (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Tue, 7 Apr 2015 09:56:38 -0400
X-Session-Marker: 726F737465647440676F6F646D69732E6F7267
X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,rostedt@goodmis.org,:::::::::::,RULES_HIT:41:355:379:541:599:800:960:968:973:982:988:989:1260:1277:1311:1313:1314:1345:1359:1437:1515:1516:1518:1534:1541:1593:1594:1711:1730:1747:1777:1792:2393:2553:2559:2562:2893:3138:3139:3140:3141:3142:3167:3353:3622:3865:3866:3867:3868:3870:3871:3872:3873:3874:4250:4321:4605:5007:6119:6261:7576:7875:7903:9040:10004:10400:10848:10967:11026:11232:11658:11914:12296:12517:12519:12555:12740:13019:13069:13161:13229:13311:13357:21067:21080,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0
X-HE-Tag: angle89_9103734983218
X-Filterd-Recvd-Size: 2526
Date: Tue, 7 Apr 2015 09:56:35 -0400
From: Steven Rostedt <rostedt@goodmis.org>
To: Juri Lelli <juri.lelli@arm.com>
Cc: Borislav Petkov <bp@alien8.de>, Ingo Molnar <mingo@kernel.org>,
        LKML <linux-kernel@vger.kernel.org>,
        "Peter Zijlstra (Intel)" <peterz@infradead.org>,
        Juri Lelli <juri.lelli@gmail.com>
Subject: Re: [PATCH] sched/core: Drop debugging leftover trace_printk call
Message-ID: <20150407095635.61cdb980@gandalf.local.home>
In-Reply-To: <5523E006.4050507@arm.com>
References: <1428050570-21041-1-git-send-email-bp@alien8.de>
	<5523E006.4050507@arm.com>
X-Mailer: Claws Mail 3.11.1 (GTK+ 2.24.25; x86_64-pc-linux-gnu)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 1760
Lines: 52

On Tue, 07 Apr 2015 14:47:50 +0100
Juri Lelli <juri.lelli@arm.com> wrote:

> On 03/04/2015 09:42, Borislav Petkov wrote:
> > From: Borislav Petkov <bp@suse.de>
> > 
> > Commit
> > 
> >   3c18d447b3b3 ("sched/core: Check for available DL bandwidth in cpuset_cpu_inactive()")
> > 
> > forgot a trace_printk debugging piece in and Steve's banner blew in
> > dmesg. Remove it.
> >
> 
> Argh! Sorry about that! Shame on me, I didn't pay much attention to
> Rostedt's banner because I was working on several fixes at once :(.

Right, but it lets other people notice it :-)



> diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
> index d124359..1fc454c5 100755
> --- a/scripts/checkpatch.pl
> +++ b/scripts/checkpatch.pl
> @@ -3257,6 +3257,12 @@ sub process {
>  			     "Prefer printk_ratelimited or pr_<level>_ratelimited to printk_ratelimit\n" . $herecurr);
>  		}
>  
> +# check for uses of trace_printk
> +		if ($line =~ /\btrace_printk\s*\(/) {
> +			ERROR("TRACE_PRINTK",
> +			      "Never use trace_printk in production code!\n" . $herecurr);
> +		}
> +

if you want to be robust here. You probably want to make an exception
when the code is in kernel/trace/ because "trace_printk" in patches
there would be to fix the trace_printk implementation, and not its use.

-- Steve


>  # printk should use KERN_* levels.  Note that follow on printk's on the
>  # same line do not need a level, so we use the current block context
>  # to try and find and validate the current printk.  In summary the current

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/