Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755156AbbDGOAe (ORCPT ); Tue, 7 Apr 2015 10:00:34 -0400 Received: from mail-qc0-f174.google.com ([209.85.216.174]:33046 "EHLO mail-qc0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753087AbbDGOAa (ORCPT ); Tue, 7 Apr 2015 10:00:30 -0400 Date: Tue, 7 Apr 2015 10:00:26 -0400 From: Tejun Heo To: Aleksa Sarai Cc: lizefan@huawei.com, mingo@redhat.com, peterz@infradead.org, richard@nod.at, =?iso-8859-1?Q?Fr=E9d=E9ric?= Weisbecker , linux-kernel@vger.kernel.org, cgroups@vger.kernel.org Subject: Re: [PATCH v8 3/4] cgroups: allow a cgroup subsystem to reject a fork Message-ID: <20150407140026.GK10582@htj.duckdns.org> References: <1427878641-5273-1-git-send-email-cyphar@cyphar.com> <1427878641-5273-4-git-send-email-cyphar@cyphar.com> <20150401160258.GP9974@htj.duckdns.org> <20150406150536.GA10582@htj.duckdns.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 977 Lines: 26 On Tue, Apr 07, 2015 at 11:47:02PM +1000, Aleksa Sarai wrote: > > [...] I don't > > think it's a good idea to send the patches as-are because we can't > > debug and fix them properly, right? [...] > > In what way are they hard to debug? Some failures can happen before console init and figuring out what's going on can be tricky. ... > difference between having an array of CGROUP_SUBSYS_COUNT pointers or > CGROUP_PREFORK_COUNT is the few bytes of memory you've "saved" (at the expense > of making the callback code essentially unreadable). Hmmm? Just define a marker macro so that the index can be extracted and loop over the indices and call the callbacks? Why would this be any more complex than anything else? -- tejun -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/