Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1755279AbbDGODX (ORCPT <rfc822;w@1wt.eu>);
	Tue, 7 Apr 2015 10:03:23 -0400
Received: from mail-wi0-f172.google.com ([209.85.212.172]:37942 "EHLO
	mail-wi0-f172.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1753942AbbDGODW (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Tue, 7 Apr 2015 10:03:22 -0400
Date: Tue, 7 Apr 2015 16:03:17 +0200
From: Ingo Molnar <mingo@kernel.org>
To: Alexander Kuleshov <kuleshovmail@gmail.com>
Cc: Thomas Gleixner <tglx@linutronix.de>, Ingo Molnar <mingo@redhat.com>,
        "H. Peter Anvin" <hpa@zytor.com>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/2 v2] x86_64/earlyprintk: setup earlyprintk as early as
 possible
Message-ID: <20150407140316.GA17681@gmail.com>
References: <1428404540-16601-1-git-send-email-kuleshovmail@gmail.com>
 <20150407110931.GC14136@gmail.com>
 <CANCZXo4-fJCE=+rhwvcQa=cEOcuZk7XTeWaU4eJUOYxYRa7_nQ@mail.gmail.com>
 <20150407113502.GA14704@gmail.com>
 <CANCZXo7VkpDdzAYR7Mw3=v_v=ckRje7rTjK-2upKd3bBo4Mefw@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CANCZXo7VkpDdzAYR7Mw3=v_v=ckRje7rTjK-2upKd3bBo4Mefw@mail.gmail.com>
User-Agent: Mutt/1.5.23 (2014-03-12)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 1170
Lines: 43


* Alexander Kuleshov <kuleshovmail@gmail.com> wrote:

> 2015-04-07 17:35 GMT+06:00 Ingo Molnar <mingo@kernel.org>:
> >
> >
> > So if you set up earlyprintk via CONFIG_CMDLINE_OVERRIDE it just
> > works?
> >
> 
> Look, how i did it. I set:
> 
> CONFIG_CMDLINE_BOOL =y
> CONFIG_CMDLINE_OVERRIDE =y
> 
> and passed following string:
> 
> [=root=/dev/sdb earlyprintk=ttyS0 loglevel=7 debug rdinit=/sbin/init
> root=/dev/ram memblock=debug]
> 
> to the CONFIG_CMDLINE.
> 
> Now i put two early_printk calls before and after earlyprintk initialization:
> 
>     early_printk("before setup_early_printk \n");
>     setup_early_printk(boot_command_line);
>     early_printk("after setup_early_printk \n");
> 
> And i don't see first string, but see last.
> 
> Did i make something wrong?

Yes, you need to check how and where in the arch init code 
boot_command_line is set up in the CONFIG_CMDLINE_OVERRIDE=y case.

Thanks,

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/