Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756432AbbDGOrp (ORCPT ); Tue, 7 Apr 2015 10:47:45 -0400 Received: from mx1.redhat.com ([209.132.183.28]:35350 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755539AbbDGOrm (ORCPT ); Tue, 7 Apr 2015 10:47:42 -0400 From: Jeff Moyer To: Ming Lei Cc: Jens Axboe , Linux Kernel Mailing List Subject: Re: [PATCH 2/2] blk-plug: don't flush nested plug lists References: <1428347694-17704-1-git-send-email-jmoyer@redhat.com> <1428347694-17704-2-git-send-email-jmoyer@redhat.com> X-PGP-KeyID: 1F78E1B4 X-PGP-CertKey: F6FE 280D 8293 F72C 65FD 5A58 1FF8 A7CA 1F78 E1B4 X-PCLoadLetter: What the f**k does that mean? Date: Tue, 07 Apr 2015 10:47:40 -0400 In-Reply-To: (Ming Lei's message of "Tue, 7 Apr 2015 17:19:35 +0800") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1117 Lines: 37 Ming Lei writes: > Hi Jeff, Hi, Ming. Thanks for reviewing! >> Unpatched kernel: >> Read B/W: 283,638 KB/s >> Read Merges: 0 >> >> Patched kernel: >> Read B/W: 873,224 KB/s >> Read Merges: 2,046K > > The data is amazing, but maybe better to provide some latency > data. Yes, good point. I'll include the full fio output in the next posting. >> Much of the patch involves modifying call sites to blk_start_plug, >> since its signature is changed. The meat of the patch is actually > > I am wondering if the type of blk_start_plug has to be changed > since the active plug is always the top plug with your patch, and > blk_finish_plug() can find the active plug from current->plug. That is a much simpler idea, thank you. I think blk_finish_plug shouldn't take the plug argument, though, since it won't actually use it. Cheers, Jeff -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/