Date: Tue, 7 Apr 2015 16:57:38 +0200
From: Borislav Petkov <bp@suse.de>
To: Aravind Gopalakrishnan <aravind.gopalakrishnan@amd.com>
Cc: Ingo Molnar <mingo@kernel.org>, tglx@linutronix.de, mingo@redhat.com,
        hpa@zytor.com, x86@kernel.org, bhelgaas@google.com,
        linux-kernel@vger.kernel.org, Suravee.Suthikulpanit@amd.com,
        joro@8bytes.org
Subject: Re: [PATCH] x86, aperture: Check for GART before accessing GART
 registers
Message-ID: <20150407145737.GB3681@pd.tnic>
References: <551D661D.3030000@amd.com>
 <20150402160634.GB8045@gmail.com>
 <551D6CF5.1010604@amd.com>
 <20150402165356.GE4579@pd.tnic>
 <551D7695.2010509@amd.com>
 <20150402171705.GF4579@pd.tnic>
 <20150402181903.GA8723@gmail.com>
 <5523125E.2010605@amd.com>
 <20150407123457.GA3681@pd.tnic>
 <5523EDC2.5080206@amd.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <5523EDC2.5080206@amd.com>
User-Agent: Mutt/1.5.23 (2014-03-12)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 852
Lines: 29

On Tue, Apr 07, 2015 at 09:46:26AM -0500, Aravind Gopalakrishnan wrote:
> Okay. I'll do that and correct the typos Ingo pointed out earlier and
> resend.

Btw, I think you should do the same in early_gart_iommu_check() too.

Doing the testing this way would mean that we first are testing for GART
hw presence and then do the rest of checks. If no GART hw, the rest of
the checks are meaningless.

Also, when testing do a "pci=noearly" boot which should make

	!early_pci_allowed()

true and thus test that path too.

Thanks.

-- 
Regards/Gruss,
    Boris.

ECO tip #101: Trim your mails when you reply.
--
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/