Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756087AbbDGPsN (ORCPT ); Tue, 7 Apr 2015 11:48:13 -0400 Received: from kiutl.biot.com ([31.172.244.210]:45370 "EHLO kiutl.biot.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753160AbbDGPsJ (ORCPT ); Tue, 7 Apr 2015 11:48:09 -0400 Message-ID: <5523FC32.3080904@biot.com> Date: Tue, 07 Apr 2015 17:48:02 +0200 From: Bert Vermeulen User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 MIME-Version: 1.0 To: Lee Jones CC: ralf@linux-mips.org, sameo@linux.intel.com, linux-mips@linux-mips.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mfd: Add support for CPLD chip on Mikrotik RB4xx boards References: <1428285076-14269-1-git-send-email-bert@biot.com> <20150407065217.GC3461@x1> In-Reply-To: <20150407065217.GC3461@x1> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1623 Lines: 40 On 07/04/15 08:52, Lee Jones wrote: > On Mon, 06 Apr 2015, Bert Vermeulen wrote: > >> The SPI-connected CPLD chip controls access to the main NAND flash >> chip and five LEDs. >> >> Signed-off-by: Bert Vermeulen >> --- >> arch/mips/include/asm/mach-ath79/rb4xx_cpld.h | 49 +++++ >> drivers/mfd/Kconfig | 7 + >> drivers/mfd/Makefile | 1 + >> drivers/mfd/rb4xx-cpld.c | 279 ++++++++++++++++++++++++++ >> 4 files changed, 336 insertions(+) >> create mode 100644 arch/mips/include/asm/mach-ath79/rb4xx_cpld.h >> create mode 100644 drivers/mfd/rb4xx-cpld.c > > This device doesn't look like an MFD, it rather looks like a CPLD > driver. We had a recent submission like this [1], perhaps this will > provide another argument for drivers/programmables or something. > > [1] https://lkml.org/lkml/2015/2/17/42 Yup, got bounced into drivers/mfd after initially submitting it as an SPI protocol driver (where it lives in openwrt). Indeed it's not a great fit anywhere -- not even programmables: this thing has its firmware on board, nothing ever feeds it on startup. Drivers for CPLDs don't necessarily have anything in common -- these are customized chips basically. In this case it's a NAND controller and GPIO/LED expander rolled into one. -- Bert Vermeulen bert@biot.com -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/