Date: Tue, 7 Apr 2015 12:43:07 -0400
From: Steven Rostedt <rostedt@goodmis.org>
To: Borislav Petkov <bp@alien8.de>
Cc: Daniel Thompson <daniel.thompson@linaro.org>,
        Thomas Gleixner <tglx@linutronix.de>,
        Jason Cooper <jason@lakedaemon.net>,
        Russell King <linux@arm.linux.org.uk>,
        Will Deacon <will.deacon@arm.com>,
        Catalin Marinas <catalin.marinas@arm.com>,
        Marc Zyngier <marc.zyngier@arm.com>,
        Stephen Boyd <sboyd@codeaurora.org>,
        John Stultz <john.stultz@linaro.org>, linux-kernel@vger.kernel.org,
        linux-arm-kernel@lists.infradead.org, patches@linaro.org,
        linaro-kernel@lists.linaro.org, Sumit Semwal <sumit.semwal@linaro.org>,
        Dirk Behme <dirk.behme@de.bosch.com>,
        Daniel Drake <drake@endlessm.com>,
        Dmitry Pervushin <dpervushin@gmail.com>,
        Tim Sander <tim@krieglstein.org>, "H. Peter Anvin" <hpa@zytor.com>,
        x86@kernel.org
Subject: Re: [RESEND PATCH 4.0-rc5 v19 5/6] x86/nmi: Use common printk
 functions
Message-ID: <20150407124307.58c7dd20@gandalf.local.home>
In-Reply-To: <20150407163746.GA14115@pd.tnic>
References: <1427216014-5324-1-git-send-email-daniel.thompson@linaro.org>
	<1428421083-9137-1-git-send-email-daniel.thompson@linaro.org>
	<1428421083-9137-6-git-send-email-daniel.thompson@linaro.org>
	<20150407121942.627d2165@gandalf.local.home>
	<20150407163746.GA14115@pd.tnic>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 483
Lines: 20

On Tue, 7 Apr 2015 18:37:46 +0200
Borislav Petkov <bp@alien8.de> wrote:


> I would simply say:
> 
> 	err = printk_nmi_backtrace_prepare();
> 	if (err)
> 
> like sane kernel code does.
> 

Yes, that is even the better solution.

-- Steve
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/