Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755061AbbDGQt2 (ORCPT ); Tue, 7 Apr 2015 12:49:28 -0400 Received: from mail-ob0-f174.google.com ([209.85.214.174]:34731 "EHLO mail-ob0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755032AbbDGQtY (ORCPT ); Tue, 7 Apr 2015 12:49:24 -0400 MIME-Version: 1.0 In-Reply-To: <20150407140316.GA17681@gmail.com> References: <1428404540-16601-1-git-send-email-kuleshovmail@gmail.com> <20150407110931.GC14136@gmail.com> <20150407113502.GA14704@gmail.com> <20150407140316.GA17681@gmail.com> Date: Tue, 7 Apr 2015 22:49:06 +0600 Message-ID: Subject: Re: [PATCH 1/2 v2] x86_64/earlyprintk: setup earlyprintk as early as possible From: Alexander Kuleshov To: Ingo Molnar Cc: Thomas Gleixner , Ingo Molnar , "H. Peter Anvin" , Greg Kroah-Hartman , LKML Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1221 Lines: 29 * 2015-04-07 20:03 GMT+06:00 Ingo Molnar : > > Yes, you need to check how and where in the arch init code > boot_command_line is set up in the CONFIG_CMDLINE_OVERRIDE=y case. > arch setup code defines builtin_cmdline and initalizes it with CONFIG_CMDLINE, which is 'root=/dev/sdb earlyprintk=ttyS0 loglevel=7 debug rdinit=/sbin/init root=/dev/ram memblock=debug' string in my test. During kernel initialization (int setup_arch), builtin_cmdline copying to the boot_command_line if CONFIG_CMDLINE_OVERRIDE and CONFIG_CMDLINE_BOOL are set. I think that it is not correct to pass boot_command_line to the setup_early_printk in CONFIG_CMDLINE_OVERRIDE=y case. As boot_command_line will be overwritten with builtin_cmdline. What do you think if we'll builtin_cmdline from the arch/x86/kernel/setup.c to the init.h to make it visible for head_{32,64}.c and pass builtin_cmdline or boot_command_line to the setup_early_printk depend on CONFIG_CMDLINE_OVERRIDE? -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/