MIME-Version: 1.0
In-Reply-To: <CANCZXo6be=TWba+1rCQs101O48YnbQ0LeVLz-B1DJ-2w8vdy6Q@mail.gmail.com>
References: <1428404540-16601-1-git-send-email-kuleshovmail@gmail.com>
	<20150407110931.GC14136@gmail.com>
	<CANCZXo4-fJCE=+rhwvcQa=cEOcuZk7XTeWaU4eJUOYxYRa7_nQ@mail.gmail.com>
	<20150407113502.GA14704@gmail.com>
	<CANCZXo7VkpDdzAYR7Mw3=v_v=ckRje7rTjK-2upKd3bBo4Mefw@mail.gmail.com>
	<20150407140316.GA17681@gmail.com>
	<CANCZXo6be=TWba+1rCQs101O48YnbQ0LeVLz-B1DJ-2w8vdy6Q@mail.gmail.com>
Date: Tue, 7 Apr 2015 23:00:30 +0600
Message-ID: <CANCZXo6UbmoTChfTQisK1gcoMhkZkPLtX8fqaAA_Vn-0Xdnx8g@mail.gmail.com>
Subject: Re: [PATCH 1/2 v2] x86_64/earlyprintk: setup earlyprintk as early as possible
From: Alexander Kuleshov <kuleshovmail@gmail.com>
To: Ingo Molnar <mingo@kernel.org>
Cc: Thomas Gleixner <tglx@linutronix.de>, Ingo Molnar <mingo@redhat.com>,
        "H. Peter Anvin" <hpa@zytor.com>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        LKML <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset=UTF-8
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1492
Lines: 34

2015-04-07 22:49 GMT+06:00 Alexander Kuleshov <kuleshovmail@gmail.com>:
> * 2015-04-07 20:03 GMT+06:00 Ingo Molnar <mingo@kernel.org>:
>>
>> Yes, you need to check how and where in the arch init code
>> boot_command_line is set up in the CONFIG_CMDLINE_OVERRIDE=y case.
>>
>
> arch setup code defines builtin_cmdline and initalizes it with
> CONFIG_CMDLINE, which
> is 'root=/dev/sdb earlyprintk=ttyS0 loglevel=7 debug rdinit=/sbin/init
> root=/dev/ram memblock=debug' string in my test. During kernel
> initialization (int setup_arch),
> builtin_cmdline copying to the boot_command_line if CONFIG_CMDLINE_OVERRIDE and
> CONFIG_CMDLINE_BOOL are set.
>
> I think that it is not correct to pass boot_command_line to the
> setup_early_printk in
> CONFIG_CMDLINE_OVERRIDE=y case. As boot_command_line will be overwritten with
> builtin_cmdline.
>
> What do you think if we'll builtin_cmdline from the
> arch/x86/kernel/setup.c to the init.h to
> make it visible for head_{32,64}.c and pass builtin_cmdline or
> boot_command_line to
> the setup_early_printk depend on  CONFIG_CMDLINE_OVERRIDE?

No, it's the wrong way. CONFIG_CMDLINE_BOOL can be 'y', but
CONFIG_CMDLINE_OVERRIDE
will be 'n', and boot_command_line will be appended, but not overwritten
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/