From: James Hartley <James.Hartley@imgtec.com>
To: Andrew Bresticker <abrestic@chromium.org>, Arnd Bergmann <arnd@arndb.de>
CC: "David S. Miller" <davem@davemloft.net>,
        Giuseppe Cavallaro <peppe.cavallaro@st.com>,
        "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Govindraj Raja <Govindraj.Raja@imgtec.com>,
        Damien Horsley <Damien.Horsley@imgtec.com>
Subject: RE: [PATCH V2 2/2] stmmac: Add IMG Pistachio platform glue layer
Thread-Topic: [PATCH V2 2/2] stmmac: Add IMG Pistachio platform glue layer
Thread-Index: AQHQcLKdgfMbPCeTSEW9tiEH03rwkZ1Aet6AgAAEt4CAAUs0EA==
Date: Tue, 7 Apr 2015 17:16:55 +0000
Message-ID: <72BC0C8BD7BB6F45988A99382E5FBAE544490C96@hhmail02.hh.imgtec.org>
References: <1428356558-18367-1-git-send-email-abrestic@chromium.org>
	<1428356558-18367-2-git-send-email-abrestic@chromium.org>
	<2916148.ZqFzHAuDtr@wuerfel>
 <CAL1qeaFwt-VB6rUywHZ47gOx4fhd6LZLfvwqkydOtqWLkYbO8A@mail.gmail.com>
In-Reply-To: <CAL1qeaFwt-VB6rUywHZ47gOx4fhd6LZLfvwqkydOtqWLkYbO8A@mail.gmail.com>
Accept-Language: en-GB, en-US
Content-Language: en-US
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Sender: linux-kernel-owner@vger.kernel.org
Content-Transfer-Encoding: 8bit
Content-Length: 1732
Lines: 40


> -----Original Message-----
> From: abrestic@google.com [mailto:abrestic@google.com] On Behalf Of
> Andrew Bresticker
> Sent: 06 April 2015 23:28
> To: Arnd Bergmann; James Hartley
> Cc: David S. Miller; Giuseppe Cavallaro; devicetree@vger.kernel.org;
> netdev@vger.kernel.org; linux-kernel@vger.kernel.org; Govindraj Raja
> Subject: Re: [PATCH V2 2/2] stmmac: Add IMG Pistachio platform glue layer
> 
> On Mon, Apr 6, 2015 at 3:10 PM, Arnd Bergmann <arnd@arndb.de> wrote:
> > On Monday 06 April 2015 14:42:38 Andrew Bresticker wrote:
> >> At the moment, the only additional setup required for the DWMAC on
> >> the IMG Pistachio SoC is to request and enable a separate gate clock
> >> for the register interface.
> >>
> >> Signed-off-by: Andrew Bresticker <abrestic@chromium.org>
> >> Signed-off-by: Govindraj Raja <govindraj.raja@imgtec.com>
> >> Cc: James Hartley <james.hartley@imgtec.com>
> >
> > Why do you need a special glue driver for that?
> >
> > Since you don't do anything special, I'd say it should be possible to
> > handle this with just the default driver.
> 
> Right, at the moment we only need to request and enable a second clock,
> which could be added to the core driver.  If we don't expect to have to
> extend this driver to deal with other configurations (which IIRC there were
> some concerns about when I wrote this), then I'm fine with folding this change
> into the core driver - James?

Weren't the concerns about USB not Ethernet?  I don't remember anything that would stop us extending the driver for eth.

> 
> Thanks,
> Andrew

James.
????{.n?+???????+%?????ݶ??w??{.n?+????{??G?????{ay?ʇڙ?,j??f???h?????????z_??(?階?ݢj"???m??????G????????????&???~???iO???z??v?^?m????????????I?