Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753138AbbDGRan (ORCPT ); Tue, 7 Apr 2015 13:30:43 -0400 Received: from mail-ob0-f170.google.com ([209.85.214.170]:36732 "EHLO mail-ob0-f170.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750862AbbDGRak (ORCPT ); Tue, 7 Apr 2015 13:30:40 -0400 MIME-Version: 1.0 In-Reply-To: References: <1428404540-16601-1-git-send-email-kuleshovmail@gmail.com> <20150407110931.GC14136@gmail.com> <20150407113502.GA14704@gmail.com> <20150407140316.GA17681@gmail.com> Date: Tue, 7 Apr 2015 23:30:30 +0600 Message-ID: Subject: Re: [PATCH 1/2 v2] x86_64/earlyprintk: setup earlyprintk as early as possible From: Alexander Kuleshov To: Ingo Molnar Cc: Thomas Gleixner , Ingo Molnar , "H. Peter Anvin" , Greg Kroah-Hartman , LKML Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 942 Lines: 25 What do you think about following way to solve this: 1. To move this code: - https://github.com/torvalds/linux/blob/master/arch/x86/kernel/setup.c#L971-L982 to the separate function, something like setup_cmdline(). 2. Call setup_cmdline in head{32,64}.c and call setup_early_printk(boot_command_line) right after this. After execution of the setup_cmdline, boot_command_line will be in actual state. It will contain command line which we passed to the kernel directly, or overwriten with CONFIG_CMDLINE_OVERRIDE, or appended with CONFIG_CMDLINE_OVERRIDE. What do you think about this? I already did it and tested on my local machine and it works, but maybe I have missed something important. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/