Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753497AbbDGRtk (ORCPT ); Tue, 7 Apr 2015 13:49:40 -0400 Received: from mail-db3on0076.outbound.protection.outlook.com ([157.55.234.76]:30627 "EHLO emea01-db3-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753112AbbDGRtf (ORCPT ); Tue, 7 Apr 2015 13:49:35 -0400 Message-ID: <552418A1.1090606@ezchip.com> Date: Tue, 7 Apr 2015 13:49:21 -0400 From: Chris Metcalf User-Agent: Mozilla/5.0 (X11; Linux i686 on x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 MIME-Version: 1.0 To: Sasha Levin , Frederic Weisbecker , Don Zickus , Ingo Molnar , Andrew Morton , Andrew Jones , chai wen , Ulrich Obergfell , Fabian Frederick , Aaron Tomlin , Ben Zhang , Christoph Lameter , Gilad Ben-Yossef , Steven Rostedt , , Jonathan Corbet , , Thomas Gleixner , Peter Zijlstra Subject: Re: [PATCH v5 2/2] watchdog: add watchdog_exclude sysctl to assist nohz References: <1258649504.12464273.1428252407339.JavaMail.zimbra@redhat.com> <1428349556-21873-1-git-send-email-cmetcalf@ezchip.com> <1428349556-21873-3-git-send-email-cmetcalf@ezchip.com> <5523FE48.2070808@oracle.com> In-Reply-To: <5523FE48.2070808@oracle.com> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [12.216.194.146] X-ClientProxiedBy: BLUPR11CA0076.namprd11.prod.outlook.com (10.141.30.44) To VI1PR02MB0781.eurprd02.prod.outlook.com (25.162.14.143) Authentication-Results: infradead.org; dkim=none (message not signed) header.d=none; X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:VI1PR02MB0781; X-Forefront-Antispam-Report: BMV:1;SFV:NSPM;SFS:(10009020)(6009001)(6049001)(24454002)(377454003)(479174004)(122386002)(83506001)(65816999)(65806001)(33656002)(99136001)(65956001)(87976001)(66066001)(77156002)(62966003)(36756003)(19580405001)(47776003)(107886001)(15975445007)(86362001)(76176999)(40100003)(2950100001)(46102003)(77096005)(87266999)(50466002)(80316001)(42186005)(64126003)(50986999)(19580395003)(92566002)(54356999)(921003)(1121003)(18886065003);DIR:OUT;SFP:1101;SCL:1;SRVR:VI1PR02MB0781;H:[10.7.0.41];FPR:;SPF:None;MLV:sfv;LANG:en; X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004)(5002010)(5005006);SRVR:VI1PR02MB0781;BCL:0;PCL:0;RULEID:;SRVR:VI1PR02MB0781; X-Forefront-PRVS: 0539EEBD11 X-OriginatorOrg: ezchip.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Apr 2015 17:49:30.1351 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR02MB0781 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 758 Lines: 23 On 04/07/2015 11:56 AM, Sasha Levin wrote: > On 04/06/2015 03:45 PM, cmetcalf@ezchip.com wrote: >> void __init lockup_detector_init(void) >> { >> set_sample_period(); >> >> + alloc_bootmem_cpumask_var(&watchdog_exclude_mask); > This happens pretty late in the boot process and should just be: > > alloc_cpumask_var(&watchdog_exclude_mask, GFP_KERNEL); Thanks; fixed. It will be in the v6 patch, which should be the final one, I think. -- Chris Metcalf, EZChip Semiconductor http://www.ezchip.com -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/