Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753356AbbDGSlF (ORCPT ); Tue, 7 Apr 2015 14:41:05 -0400 Received: from www.linutronix.de ([62.245.132.108]:39603 "EHLO Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750881AbbDGSlB (ORCPT ); Tue, 7 Apr 2015 14:41:01 -0400 Date: Tue, 7 Apr 2015 20:41:24 +0200 (CEST) From: Thomas Gleixner To: Sebastian Andrzej Siewior cc: linux-kernel@vger.kernel.org, Peter Zijlstra , Ingo Molnar , Darren Hart , Steven Rostedt , fredrik.markstrom@windriver.com, Davidlohr Bueso , Manfred Spraul Subject: Re: [PATCH 1/3] futex: avoid double wake up in PI futex wait / wake on -RT In-Reply-To: <1428419030-20030-2-git-send-email-bigeasy@linutronix.de> Message-ID: References: <1428419030-20030-1-git-send-email-bigeasy@linutronix.de> <1428419030-20030-2-git-send-email-bigeasy@linutronix.de> User-Agent: Alpine 2.11 (DEB 23 2013-08-11) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-Linutronix-Spam-Score: -1.0 X-Linutronix-Spam-Level: - X-Linutronix-Spam-Status: No , -1.0 points, 5.0 required, ALL_TRUSTED=-1,SHORTCIRCUIT=-0.0001 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 818 Lines: 24 On Tue, 7 Apr 2015, Sebastian Andrzej Siewior wrote: > /* > * Wake up the next waiter on the lock. > * > - * Remove the top waiter from the current tasks pi waiter list and > - * wake it up. > + * Remove the top waiter from the current tasks pi waiter list take a > + * reference and return a pointer to it. That comment is stale from an earlier version of that patch. That should be: + * Remove the top waiter from the current tasks pi waiter list, + * wake it up and return whether the current task needs to undo + * a potential priority boosting. Thanks, tglx -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/