Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753400AbbDGS4u (ORCPT ); Tue, 7 Apr 2015 14:56:50 -0400 Received: from smtp.opengridcomputing.com ([72.48.136.20]:42242 "EHLO smtp.opengridcomputing.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753203AbbDGS4p (ORCPT ); Tue, 7 Apr 2015 14:56:45 -0400 From: "Steve Wise" To: "'Hefty, Sean'" , "'Michael Wang'" , "'Roland Dreier'" , , , , Cc: "'Hal Rosenstock'" , "'Tom Tucker'" , "'Hoang-Nam Nguyen'" , "'Christoph Raisch'" , "'infinipath'" , "'Eli Cohen'" , "'Latif, Faisal'" , "'Upinder Malhi'" , "'Trond Myklebust'" , "'J. Bruce Fields'" , "'David S. Miller'" , "'Weiny, Ira'" , "'PJ Waskiewicz'" , "'Nikolova, Tatyana E'" , "'Or Gerlitz'" , "'Jack Morgenstein'" , "'Haggai Eran'" , "'Ilya Nelkenbaum'" , "'Yann Droneaud'" , "'Bart Van Assche'" , "'Shachar Raindel'" , "'Sagi Grimberg'" , "'Devesh Sharma'" , "'Matan Barak'" , "'Moni Shoua'" , "'Jiri Kosina'" , "'Selvin Xavier'" , "'Mitesh Ahuja'" , "'Li RongQing'" , "'Rasmus Villemoes'" , "'Estrin, Alex'" , "'Doug Ledford'" , "'Eric Dumazet'" , "'Erez Shitrit'" , "'Tom Gundersen'" , "'Chuck Lever'" References: <5523CCD5.6030401@profitbricks.com> <5523CF30.7000608@profitbricks.com> <1828884A29C6694DAF28B7E6B8A82373A8FBE2FA@ORSMSX109.amr.corp.intel.com> In-Reply-To: <1828884A29C6694DAF28B7E6B8A82373A8FBE2FA@ORSMSX109.amr.corp.intel.com> Subject: RE: [PATCH v2 11/17] IB/Verbs: Reform link_layer_show() and ib_uverbs_query_port() Date: Tue, 7 Apr 2015 13:56:47 -0500 Message-ID: <005e01d07164$9954e390$cbfeaab0$@opengridcomputing.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-Mailer: Microsoft Outlook 14.0 Thread-Index: AQIODKAa2UtVTyWRv0vHrAVLc3hwKgFxZP1mAuW0VPyco/bjwA== Content-Language: en-us Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2312 Lines: 63 > > > diff --git a/drivers/infiniband/core/sysfs.c > > b/drivers/infiniband/core/sysfs.c > > index cbd0383..aa53e40 100644 > > --- a/drivers/infiniband/core/sysfs.c > > +++ b/drivers/infiniband/core/sysfs.c > > @@ -248,14 +248,10 @@ static ssize_t phys_state_show(struct ib_port *p, > > struct port_attribute *unused, > > static ssize_t link_layer_show(struct ib_port *p, struct port_attribute > > *unused, > > char *buf) > > { > > - switch (rdma_port_get_link_layer(p->ibdev, p->port_num)) { > > - case IB_LINK_LAYER_INFINIBAND: > > + if (rdma_transport_ib(p->ibdev, p->port_num)) > > return sprintf(buf, "%s\n", "InfiniBand"); > > - case IB_LINK_LAYER_ETHERNET: > > + else > > return sprintf(buf, "%s\n", "Ethernet"); > > - default: > > - return sprintf(buf, "%s\n", "Unknown"); > > - } > > } > > > > static PORT_ATTR_RO(state); > > diff --git a/drivers/infiniband/core/uverbs_cmd.c > > b/drivers/infiniband/core/uverbs_cmd.c > > index a9f0489..3eb6eb5 100644 > > --- a/drivers/infiniband/core/uverbs_cmd.c > > +++ b/drivers/infiniband/core/uverbs_cmd.c > > @@ -515,8 +515,10 @@ ssize_t ib_uverbs_query_port(struct ib_uverbs_file > > *file, > > resp.active_width = attr.active_width; > > resp.active_speed = attr.active_speed; > > resp.phys_state = attr.phys_state; > > - resp.link_layer = rdma_port_get_link_layer(file->device- > > >ib_dev, > > - cmd.port_num); > > + resp.link_layer = rdma_transport_ib(file->device->ib_dev, > > + cmd.port_num) ? > > + IB_LINK_LAYER_INFINIBAND : > > + IB_LINK_LAYER_ETHERNET; > > > > if (copy_to_user((void __user *) (unsigned long) cmd.response, > > &resp, sizeof resp)) > > Both of the above check the transport in order to determine the link layer. > > These values are exposed to user space. Does anyone know what link layer iWarp returns to user space? Ethernet: t4:~ # ibv_devinfo -d cxgb4_0|grep link_layer link_layer: Ethernet link_layer: Ethernet Steve. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/