MIME-Version: 1.0
In-Reply-To: <CAE9FiQWutvBcFJ0MWBBVN3VyXejLZzVdJ5qBCQEox4w_HV7SPw@mail.gmail.com>
References: <1428326234-10067-1-git-send-email-kuleshovmail@gmail.com>
	<20150407095228.GA13093@gmail.com>
	<CANCZXo5Fx5rTYWNRrC4T7nkPzB9iVn7EnYpXUCTsDXxW34TwyQ@mail.gmail.com>
	<20150407102445.GA13658@gmail.com>
	<CANCZXo6VOHOz-v8V=SnprXOvbMV5tuYsfeNqwqk-TOvykLCkRQ@mail.gmail.com>
	<CAE9FiQWutvBcFJ0MWBBVN3VyXejLZzVdJ5qBCQEox4w_HV7SPw@mail.gmail.com>
Date: Tue, 7 Apr 2015 12:08:29 -0700
Message-ID: <CAE9FiQXB=tGvnNR7BoKbDzU9-zRkV444cjGSYypPmwgQ4HLNSA@mail.gmail.com>
Subject: Re: [PATCH] x86/earlyprintk: setup earlyprintk as early as possible
From: Yinghai Lu <yinghai@kernel.org>
To: Alexander Kuleshov <kuleshovmail@gmail.com>
Cc: Ingo Molnar <mingo@kernel.org>, Thomas Gleixner <tglx@linutronix.de>,
        Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        LKML <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset=UTF-8
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1126
Lines: 29

On Tue, Apr 7, 2015 at 12:07 PM, Yinghai Lu <yinghai@kernel.org> wrote:
> On Tue, Apr 7, 2015 at 3:31 AM, Alexander Kuleshov
> <kuleshovmail@gmail.com> wrote:
>
>>
>> As i already wrote, i tested it for x86_64 and it works. I will put earlyprintk
>> setup in the start of the i386_start_kernel, will test it with 32-bit
>> and resend two
>> patches if they will be good.
>
> No, that is not enough.
> early_printk would handle not only serial console with io port accessing.
> You need to make sure all other path including pciserial/dbgp/efi is safe.
> They are using early_ioremap, and you can not call early_ioremap()
> before early_ioremap.

They are using early_ioremap, and you can not call early_ioremap()
before early_ioremap_init.

>
> otherwise you may need to just search "serial string in boot command line" like
> i did in moving earlycon early patch.
>
>     Yinghai
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/