Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753490AbbDGT4V (ORCPT ); Tue, 7 Apr 2015 15:56:21 -0400 Received: from mo7.mail-out.ovh.net ([178.32.228.7]:48347 "EHLO mo7.mail-out.ovh.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752818AbbDGT4U (ORCPT ); Tue, 7 Apr 2015 15:56:20 -0400 X-Greylist: delayed 20652 seconds by postgrey-1.27 at vger.kernel.org; Tue, 07 Apr 2015 15:56:20 EDT MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Date: Tue, 07 Apr 2015 21:40:56 +0200 From: g.portay@overkiz.com To: Alexandre Belloni Cc: Nicolas Ferre , Boris Brezillon , Jean-Christophe PLAGNIOL-VILLARD , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/2] ARM: at91/dt: sam9x5: add pinctrl for pwm0 In-Reply-To: <20150407192231.GW20669@piout.net> References: <1428415884-30662-1-git-send-email-g.portay@overkiz.com> <1428415884-30662-2-git-send-email-g.portay@overkiz.com> <20150407192231.GW20669@piout.net> Message-ID: <8817d74520bc99a9ee01fe303dc335cd@overkiz.com> User-Agent: Roundcube Webmail/1.0.3 X-Originating-IP: 109.190.157.19 X-Webmail-UserID: g.portay@overkiz.com X-Ovh-Tracer-Id: 3660863550268173202 X-VR-SPAMSTATE: OK X-VR-SPAMSCORE: -100 X-VR-SPAMCAUSE: gggruggvucftvghtrhhoucdtuddrfeektddrvdelucetufdoteggodetrfcurfhrohhfihhlvgemucfqggfjnecuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1334 Lines: 43 On 2015-04-07 21:22, Alexandre Belloni wrote: > Hi Gaël, > > On 07/04/2015 at 16:11:23 +0200, Gaël PORTAY wrote : >> Defines the pinctrl configurations for PWM0. >> >> Signed-off-by: Gaël PORTAY >> --- >> arch/arm/boot/dts/at91sam9x5.dtsi | 46 >> +++++++++++++++++++++++++++++++++++++++ >> 1 file changed, 46 insertions(+) >> >> diff --git a/arch/arm/boot/dts/at91sam9x5.dtsi >> b/arch/arm/boot/dts/at91sam9x5.dtsi >> index d221179..08ed53d 100644 >> --- a/arch/arm/boot/dts/at91sam9x5.dtsi >> +++ b/arch/arm/boot/dts/at91sam9x5.dtsi >> @@ -463,6 +463,52 @@ >> }; >> }; >> >> + pwm0 { >> + pinctrl_pwm0_pwm0_0: pwm0_pwm0-0 { >> + atmel,pins = >> + ; /* PB11 periph >> B */ > please drop those useless > comments --^ > > Else, I'm fine with that patch. I do think so... I added them for consistency only... I will drop them in v2. Do you want I drop all those kind of comments (of the whole file) as well ? Thanks for your review. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/