Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753888AbbDGUSG (ORCPT ); Tue, 7 Apr 2015 16:18:06 -0400 Received: from mga02.intel.com ([134.134.136.20]:15685 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753828AbbDGUSD convert rfc822-to-8bit (ORCPT ); Tue, 7 Apr 2015 16:18:03 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.11,539,1422950400"; d="scan'208";a="676539615" From: "Hefty, Sean" To: Jason Gunthorpe , Michael Wang CC: Roland Dreier , "linux-rdma@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-nfs@vger.kernel.org" , "netdev@vger.kernel.org" , Hal Rosenstock , "Tom Tucker" , Steve Wise , Hoang-Nam Nguyen , Christoph Raisch , infinipath , Eli Cohen , "Latif, Faisal" , Upinder Malhi , "Trond Myklebust" , "J. Bruce Fields" , "David S. Miller" , "Weiny, Ira" , PJ Waskiewicz , "Nikolova, Tatyana E" , Or Gerlitz , Jack Morgenstein , "Haggai Eran" , Ilya Nelkenbaum , "Yann Droneaud" , Bart Van Assche , Shachar Raindel , Sagi Grimberg , Devesh Sharma , Matan Barak , Moni Shoua , Jiri Kosina , Selvin Xavier , Mitesh Ahuja , "Li RongQing" , Rasmus Villemoes , "Estrin, Alex" , "Doug Ledford" , Eric Dumazet , "Erez Shitrit" , Tom Gundersen , Chuck Lever Subject: RE: [PATCH v2 10/17] IB/Verbs: Adopt management helpers for IB helpers Thread-Topic: [PATCH v2 10/17] IB/Verbs: Adopt management helpers for IB helpers Thread-Index: AQHQcS9UNVMNFw8QqkKGXKPnXs/bLp1CcXaA//+L4NA= Date: Tue, 7 Apr 2015 20:18:00 +0000 Message-ID: <1828884A29C6694DAF28B7E6B8A82373A8FBE3B0@ORSMSX109.amr.corp.intel.com> References: <5523CCD5.6030401@profitbricks.com> <5523CF0A.5090206@profitbricks.com> <20150407201259.GA17147@obsidianresearch.com> In-Reply-To: <20150407201259.GA17147@obsidianresearch.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.22.254.138] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 849 Lines: 20 > > index f704254..4e61104 100644 > > +++ b/drivers/infiniband/core/sa_query.c > > @@ -540,7 +540,7 @@ int ib_init_ah_from_path(struct ib_device *device, > u8 port_num, > > ah_attr->port_num = port_num; > > ah_attr->static_rate = rec->rate; > > > > - force_grh = rdma_port_get_link_layer(device, port_num) == > IB_LINK_LAYER_ETHERNET; > > + force_grh = !rdma_transport_ib(device, port_num); > > Maybe these tests should be called cap_mandatory_grh - but I'm not > really sure how iWarp uses the GRH fields in the AH... AH are used with unconnected endpoints, which iWarp doesn't currently support. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/