Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753998AbbDHBub (ORCPT ); Tue, 7 Apr 2015 21:50:31 -0400 Received: from mail-qk0-f177.google.com ([209.85.220.177]:35177 "EHLO mail-qk0-f177.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753213AbbDHBu1 (ORCPT ); Tue, 7 Apr 2015 21:50:27 -0400 MIME-Version: 1.0 In-Reply-To: <5523F10D.20801@collabora.co.uk> References: <1427730803-28635-1-git-send-email-javier.martinez@collabora.co.uk> <1427730803-28635-3-git-send-email-javier.martinez@collabora.co.uk> <551976F1.1000605@collabora.co.uk> <551AFCCE.4050404@collabora.co.uk> <551BD07E.2090506@samsung.com> <551BDA0A.7010704@collabora.co.uk> <551C2B6D.4010001@samsung.com> <551C71A5.1070903@collabora.co.uk> <5523B878.8040304@collabora.co.uk> <5523C5F5.6000604@collabora.co.uk> <5523E5A9.4080302@collabora.co.uk> <5523F10D.20801@collabora.co.uk> Date: Wed, 8 Apr 2015 07:20:26 +0530 Message-ID: Subject: Re: [RFC PATCH v3 2/2] clk: exynos5420: Make sure MDMA0 clock is enabled during suspend From: Abhilash Kesavan To: Javier Martinez Canillas Cc: Tomasz Figa , Sylwester Nawrocki , Stephen Boyd , Mike Turquette , Kukjin Kim , Olof Johansson , Doug Anderson , Krzysztof Kozlowski , Kevin Hilman , Tyler Baker , Chanwoo Choi , linux-arm-kernel , "linux-samsung-soc@vger.kernel.org" , linux-kernel Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2976 Lines: 65 Hi Javier, On Tue, Apr 7, 2015 at 8:30 PM, Javier Martinez Canillas wrote: > Hello Abhilash, > > On 04/07/2015 04:38 PM, Abhilash Kesavan wrote: >>> >>> [0] >>> From 78aa551ebcb9a4a7ae9d5581c33e0c0f19fe5ad6 Mon Sep 17 00:00:00 2001 >>> From: Javier Martinez Canillas >>> Date: Tue, 7 Apr 2015 15:53:27 +0200 >>> Subject: [RFC PATCH] clk: exynos5420: Restore GATE_BUS_TOP on suspend >>> >>> Commit ae43b3289186 ("ARM: 8202/1: dmaengine: pl330: Add runtime Power >>> Management support v12") added pm support for the pl330 dma driver but >>> it makes the clock for the Exynos5420 MDMA0 DMA controller to be gated >>> during suspend and this in turn makes its parent clock aclk266_g2d to >>> be gated. But the clock needs to be ungated prior suspend to allow the >>> system to be suspend and resumed correctly. >>> >>> Add GATE_BUS_TOP register to the list of registers to be restored when >>> the system enters into a suspend state so aclk266_g2d will be ungated. >>> >>> Thanks to Abhilash Kesavan for figuring out that this was the issue. >>> >>> Fixes: ae43b32 ("ARM: 8202/1: dmaengine: pl330: Add runtime Power Management support v12") >>> Signed-off-by: Javier Martinez Canillas >>> --- >>> drivers/clk/samsung/clk-exynos5420.c | 1 + >>> 1 file changed, 1 insertion(+) >>> >>> diff --git a/drivers/clk/samsung/clk-exynos5420.c b/drivers/clk/samsung/clk-exynos5420.c >>> index 07d666cc6a29..bea4a173eef5 100644 >>> --- a/drivers/clk/samsung/clk-exynos5420.c >>> +++ b/drivers/clk/samsung/clk-exynos5420.c >>> @@ -271,6 +271,7 @@ static const struct samsung_clk_reg_dump exynos5420_set_clksrc[] = { >>> { .offset = SRC_MASK_PERIC0, .value = 0x11111110, }, >>> { .offset = SRC_MASK_PERIC1, .value = 0x11111100, }, >>> { .offset = SRC_MASK_ISP, .value = 0x11111000, }, >>> + { .offset = GATE_BUS_TOP, .value = 0xffffffff, }, >>> { .offset = GATE_BUS_DISP1, .value = 0xffffffff, }, >>> { .offset = GATE_IP_PERIC, .value = 0xffffffff, }, >>> }; >> >> While there could be a concern that we are ungating all the clocks in > > Yes, I mentioned that but OTOH it will be even more dangerous to gate > clocks that should remain enabled so I used the register default values. > >> BUS_TOP, this looks like the least intrusive fix for the issue. Tested >> this on Peach Pi, S2R works fine. >> > > Thanks a lot for testing, does it mean I can add your Tested-by then when > posting it as a proper patch? I'll wait for Tomasz to comment before though. Tested-by: Abhilash Kesavan . Abhilash -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/