Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1753946AbbDHCEI (ORCPT <rfc822;w@1wt.eu>);
	Tue, 7 Apr 2015 22:04:08 -0400
Received: from szxga03-in.huawei.com ([119.145.14.66]:22825 "EHLO
	szxga03-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1751548AbbDHCEF (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Tue, 7 Apr 2015 22:04:05 -0400
Message-ID: <55248B68.7000308@huawei.com>
Date: Wed, 8 Apr 2015 09:59:04 +0800
From: Xishi Qiu <qiuxishi@huawei.com>
User-Agent: Mozilla/5.0 (Windows NT 6.1; rv:12.0) Gecko/20120428 Thunderbird/12.0.1
MIME-Version: 1.0
To: Dave Young <dyoung@redhat.com>
CC: <x86@kernel.org>, <linux-kernel@vger.kernel.org>, <tglx@linutronix.de>,
        <bhe@redhat.com>, <akpm@linux-foundation.org>,
        <isimatu.yasuaki@jp.fujitsu.com>, <mingo@redhat.com>, <hpa@zytor.com>
Subject: Re: [PATCH V2] x86/numa: kernel stack corruption fix
References: <20150407134132.GA23522@dhcp-16-198.nay.redhat.com> <5524862F.6010709@huawei.com> <20150408014630.GF7213@localhost.localdomain>
In-Reply-To: <20150408014630.GF7213@localhost.localdomain>
Content-Type: text/plain; charset="ISO-8859-1"
Content-Transfer-Encoding: 7bit
X-Originating-IP: [10.177.25.179]
X-CFilter-Loop: Reflected
X-Mirapoint-Virus-RAPID-Raw: score=unknown(0),
	refid=str=0001.0A020202.55248B6F.010E,ss=1,re=0.001,recu=0.000,reip=0.000,cl=1,cld=1,fgs=0,
	ip=0.0.0.0,
	so=2013-05-26 15:14:31,
	dmn=2013-03-21 17:37:32
X-Mirapoint-Loop-Id: 9ff37d4fda741d20fbb381f286b8ed34
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 1032
Lines: 39

On 2015/4/8 9:46, Dave Young wrote:

>>>  
>>> -	/* Mark all kernel nodes. */
>>> +	/*
>>> +	 * Mark all kernel nodes.
>>> +	 *
>>> +	 * In case booting with mem=nn[kMG] or in kdump kernel, numa_meminfo
>>
>> Hi Dave,
>>
>> It should both set mem=xx and numa=off, then numa_meminfo may not include all
>> the memblock.reserved memory, right?
> 
> Yasuaki Ishimatsu suggests to remove numa=off in comment because in theory there's such
> possiblity that it may happen even without numa=off. Just consider the non-snb board..
> 
> Thanks
> Dave
> 

Hi Dave,

I made a mistake, when numa is on, numa_meminfo is from SRAT, but it will be cut
in numa_cleanup_meminfo(), so the bug is not related to numa on/off. Your comment
is right.

Reviewed-by: Xishi Qiu <qiuxishi@huawei.com>

> .
> 



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/