Date: Wed, 8 Apr 2015 10:18:36 +0800
From: Baoquan He <bhe@redhat.com>
To: Xishi Qiu <qiuxishi@huawei.com>
Cc: Dave Young <dyoung@redhat.com>, x86@kernel.org,
        linux-kernel@vger.kernel.org, tglx@linutronix.de,
        akpm@linux-foundation.org, isimatu.yasuaki@jp.fujitsu.com,
        mingo@redhat.com, hpa@zytor.com
Subject: Re: [PATCH V2] x86/numa: kernel stack corruption fix
Message-ID: <20150408021836.GA2464@dhcp-16-105.nay.redhat.com>
References: <20150407134132.GA23522@dhcp-16-198.nay.redhat.com>
 <5524862F.6010709@huawei.com>
 <20150408014630.GF7213@localhost.localdomain>
 <55248B68.7000308@huawei.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <55248B68.7000308@huawei.com>
User-Agent: Mutt/1.5.21 (2010-09-15)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1307
Lines: 47

On 04/08/15 at 09:59am, Xishi Qiu wrote:
> On 2015/4/8 9:46, Dave Young wrote:
> 
> >>>  
> >>> -	/* Mark all kernel nodes. */
> >>> +	/*
> >>> +	 * Mark all kernel nodes.
> >>> +	 *
> >>> +	 * In case booting with mem=nn[kMG] or in kdump kernel, numa_meminfo
> >>
> >> Hi Dave,
> >>
> >> It should both set mem=xx and numa=off, then numa_meminfo may not include all
> >> the memblock.reserved memory, right?
> > 
> > Yasuaki Ishimatsu suggests to remove numa=off in comment because in theory there's such
> > possiblity that it may happen even without numa=off. Just consider the non-snb board..
> > 
> > Thanks
> > Dave
> > 
> 
> Hi Dave,
> 
> I made a mistake, when numa is on, numa_meminfo is from SRAT, but it will be cut
> in numa_cleanup_meminfo(), so the bug is not related to numa on/off. Your comment
> is right.

Hi Xishi,

>From code flow it's exact as you said. And if remove numa=off bug should
be reproduced alwasy. I talked to Dave, he said error didn't occur when
he remove numa=off. That is too weird.

Thanks
Baoquan > 
> 
> > .
> > 
> 
> 
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/