Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753819AbbDHCgm (ORCPT ); Tue, 7 Apr 2015 22:36:42 -0400 Received: from mail9.hitachi.co.jp ([133.145.228.44]:37396 "EHLO mail9.hitachi.co.jp" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751548AbbDHCgl (ORCPT ); Tue, 7 Apr 2015 22:36:41 -0400 Message-ID: <55249431.5060402@hitachi.com> Date: Wed, 08 Apr 2015 11:36:33 +0900 From: Masami Hiramatsu Organization: Hitachi, Ltd., Japan User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:13.0) Gecko/20120614 Thunderbird/13.0.1 MIME-Version: 1.0 To: Wang Nan CC: acme@kernel.org, jolsa@kernel.org, namhyung@kernel.org, mingo@redhat.com, lizefan@huawei.com, pi3orama@163.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH -tip] perf probe: fix ARM 32 building error. References: <1428459274-138470-1-git-send-email-wangnan0@huawei.com> In-Reply-To: <1428459274-138470-1-git-send-email-wangnan0@huawei.com> Content-Type: text/plain; charset=ISO-2022-JP Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1562 Lines: 49 (2015/04/08 11:14), Wang Nan wrote: > Commit 9b118acae310f57baee770b5db402500d8695e50 ("perf probe: Fix to > handle aliased symbols in glibc") uses an absolute format '%lx' to > print u64 argument, which causes compiling error on ARM 32. > > This patch replaces it with PRIx64. Good catch! :) Acked-by: Masami Hiramatsu Thanks! > > Signed-off-by: Wang Nan > --- > tools/perf/util/probe-event.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/tools/perf/util/probe-event.c b/tools/perf/util/probe-event.c > index 8feac07..3dacec9 100644 > --- a/tools/perf/util/probe-event.c > +++ b/tools/perf/util/probe-event.c > @@ -320,7 +320,8 @@ static int find_alternative_probe_point(struct debuginfo *dinfo, > ret = -ENOENT; > goto out; > } > - pr_debug("Symbol %s address found : %lx\n", pp->function, address); > + pr_debug("Symbol %s address found : %" PRIx64 "\n", > + pp->function, address); > > ret = debuginfo__find_probe_point(dinfo, (unsigned long)address, > result); > -- Masami HIRAMATSU Linux Technology Research Center, System Productivity Research Dept. Center for Technology Innovation - Systems Engineering Hitachi, Ltd., Research & Development Group E-mail: masami.hiramatsu.pt@hitachi.com -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/