Date: Wed, 8 Apr 2015 11:09:16 +0800
From: Dave Young <dyoung@redhat.com>
To: Xishi Qiu <qiuxishi@huawei.com>
Cc: Baoquan He <bhe@redhat.com>, x86@kernel.org, linux-kernel@vger.kernel.org,
        tglx@linutronix.de, akpm@linux-foundation.org,
        isimatu.yasuaki@jp.fujitsu.com, mingo@redhat.com, hpa@zytor.com
Subject: Re: [PATCH V2] x86/numa: kernel stack corruption fix
Message-ID: <20150408030821.GG7213@localhost.localdomain>
References: <20150407134132.GA23522@dhcp-16-198.nay.redhat.com>
 <5524862F.6010709@huawei.com>
 <20150408014630.GF7213@localhost.localdomain>
 <55248B68.7000308@huawei.com>
 <20150408021836.GA2464@dhcp-16-105.nay.redhat.com>
 <55249572.7010600@huawei.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <55249572.7010600@huawei.com>
User-Agent: Mutt/1.5.22.1-rc1 (2013-10-16)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1796
Lines: 56

On 04/08/15 at 10:41am, Xishi Qiu wrote:
> On 2015/4/8 10:18, Baoquan He wrote:
> 
> > On 04/08/15 at 09:59am, Xishi Qiu wrote:
> >> On 2015/4/8 9:46, Dave Young wrote:
> >>
> >>>>>  
> >>>>> -	/* Mark all kernel nodes. */
> >>>>> +	/*
> >>>>> +	 * Mark all kernel nodes.
> >>>>> +	 *
> >>>>> +	 * In case booting with mem=nn[kMG] or in kdump kernel, numa_meminfo
> >>>>
> >>>> Hi Dave,
> >>>>
> >>>> It should both set mem=xx and numa=off, then numa_meminfo may not include all
> >>>> the memblock.reserved memory, right?
> >>>
> >>> Yasuaki Ishimatsu suggests to remove numa=off in comment because in theory there's such
> >>> possiblity that it may happen even without numa=off. Just consider the non-snb board..
> >>>
> >>> Thanks
> >>> Dave
> >>>
> >>
> >> Hi Dave,
> >>
> >> I made a mistake, when numa is on, numa_meminfo is from SRAT, but it will be cut
> >> in numa_cleanup_meminfo(), so the bug is not related to numa on/off. Your comment
> >> is right.
> > 
> > Hi Xishi,
> > 
> >>From code flow it's exact as you said. And if remove numa=off bug should
> > be reproduced alwasy. I talked to Dave, he said error didn't occur when
> > he remove numa=off. That is too weird.
> > 
> 
> Hi Baoquan,
> 
> May be it wrote over end of numa mask bitmap, but the stack can still run,
> so there is no Call Trace. 
> How about add some printk to see if it has written over? 

Oops, Redhat kdump always add numa=off in 2nd kernel commandline, but I did
not notice I removed it during test.

So yes, the issue does not depend on numa=off.

Thanks
Dave
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/