Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751250AbbDHEw6 (ORCPT ); Wed, 8 Apr 2015 00:52:58 -0400 Received: from mgwkm04.jp.fujitsu.com ([202.219.69.171]:40248 "EHLO mgwkm04.jp.fujitsu.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751090AbbDHEw4 (ORCPT ); Wed, 8 Apr 2015 00:52:56 -0400 Message-ID: <5524B2C4.50009@jp.fujitsu.com> Date: Wed, 8 Apr 2015 13:47:00 +0900 From: Seiichi Ikarashi Organization: Fujitsu Limited User-Agent: Mozilla/5.0 (X11; Linux i686 on x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 MIME-Version: 1.0 To: Thomas Gleixner , "Rafael J. Wysocki" , Ingo Molnar CC: Subject: [PATCH] irq: Remove unnecessary warning with affinity_hint References: <5519D929.8080700@jp.fujitsu.com> In-Reply-To: <5519D929.8080700@jp.fujitsu.com> X-Forwarded-Message-Id: <5519D929.8080700@jp.fujitsu.com> Content-Type: text/plain; charset="iso-2022-jp" Content-Transfer-Encoding: 7bit X-SecurityPolicyCheck-GC: OK by FENCE-Mail X-TM-AS-MML: disable Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1312 Lines: 39 Hi, If you turn off a PCI device whose driver has set affinity_hint, you will get warning message which does _not_ explain the reason why it appeared from the user's point of view. # echo 0 > /sys/bus/pci/slots/65/power Apr 28 20:29:39 localhost kernel: ------------[ cut here ]------------ Apr 28 20:29:39 localhost kernel: WARNING: at kernel/irq/manage.c:1002 __free_irq+0x22d/0x250() (Tainted: P --------------- ) (snip) Users will misunderstand some problem has happened even though he or she succeeded to turn off the device. I suppose this warning was originally for a debug purpose for driver developers and has incidentally been left. Just remove the warning is good and enough. Signed-off-by: Seiichi Ikarashi --- a/kernel/irq/manage.c +++ b/kernel/irq/manage.c @@ -1335,7 +1335,7 @@ static struct irqaction *__free_irq(unsi #ifdef CONFIG_SMP /* make sure affinity_hint is cleaned up */ - if (WARN_ON_ONCE(desc->affinity_hint)) + if (desc->affinity_hint) desc->affinity_hint = NULL; #endif -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/