Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753220AbbDHI2Z (ORCPT ); Wed, 8 Apr 2015 04:28:25 -0400 Received: from mail-wi0-f173.google.com ([209.85.212.173]:38138 "EHLO mail-wi0-f173.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751403AbbDHI2P (ORCPT ); Wed, 8 Apr 2015 04:28:15 -0400 Message-ID: <5524E69A.6050400@profitbricks.com> Date: Wed, 08 Apr 2015 10:28:10 +0200 From: Michael Wang User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 MIME-Version: 1.0 To: Steve Wise , "'Jason Gunthorpe'" CC: "'Roland Dreier'" , "'Sean Hefty'" , linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org, linux-nfs@vger.kernel.org, netdev@vger.kernel.org, "'Hal Rosenstock'" , "'Tom Tucker'" , "'Hoang-Nam Nguyen'" , "'Christoph Raisch'" , "'Mike Marciniszyn'" , "'Eli Cohen'" , "'Faisal Latif'" , "'Upinder Malhi'" , "'Trond Myklebust'" , "'J. Bruce Fields'" , "'David S. Miller'" , "'Ira Weiny'" , "'PJ Waskiewicz'" , "'Tatyana Nikolova'" , "'Or Gerlitz'" , "'Jack Morgenstein'" , "'Haggai Eran'" , "'Ilya Nelkenbaum'" , "'Yann Droneaud'" , "'Bart Van Assche'" , "'Shachar Raindel'" , "'Sagi Grimberg'" , "'Devesh Sharma'" , "'Matan Barak'" , "'Moni Shoua'" , "'Jiri Kosina'" , "'Selvin Xavier'" , "'Mitesh Ahuja'" , "'Li RongQing'" , "'Rasmus Villemoes'" , "'Alex Estrin'" , "'Doug Ledford'" , "'Eric Dumazet'" , "'Erez Shitrit'" , "'Tom Gundersen'" , "'Chuck Lever'" Subject: Re: [PATCH v2 10/17] IB/Verbs: Adopt management helpers for IB helpers References: <5523CCD5.6030401@profitbricks.com> <5523CF0A.5090206@profitbricks.com> <20150407201259.GA17147@obsidianresearch.com> <008401d0716f$bc41c5c0$34c55140$@opengridcomputing.com> In-Reply-To: <008401d0716f$bc41c5c0$34c55140$@opengridcomputing.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1091 Lines: 34 Hi, Steve Thanks for the comment :-) On 04/07/2015 10:16 PM, Steve Wise wrote: [snip] >>> >>> - force_grh = rdma_port_get_link_layer(device, port_num) == IB_LINK_LAYER_ETHERNET; >>> + force_grh = !rdma_transport_ib(device, port_num); >> >> Maybe these tests should be called cap_mandatory_grh - but I'm not >> really sure how iWarp uses the GRH fields in the AH... >> > > iWARP runs on top of TCP...this SA code is all IB-specific. The reason it was checking for ETHERNET, I think, is for RoCE. So > this change is totally incorrect, I think, because RoCE is an IB transport, but it runs on ETHERNET. I guess it's the name 'transport' which confusing folks... actually (!rdma_transport_ib) including RoCE/IBoE, but yes, here it's for IBoE only, so let's change it to rdma_transport_iboe ;-) Regards, Michael Wang > > Steve. > > > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/