Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753698AbbDHIzg (ORCPT ); Wed, 8 Apr 2015 04:55:36 -0400 Received: from casper.infradead.org ([85.118.1.10]:45416 "EHLO casper.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751486AbbDHIzc (ORCPT ); Wed, 8 Apr 2015 04:55:32 -0400 Date: Wed, 8 Apr 2015 10:55:19 +0200 From: Peter Zijlstra To: Yunlong Song Cc: paulus@samba.org, mingo@redhat.com, acme@kernel.org, linux-kernel@vger.kernel.org, wangnan0@huawei.com Subject: Re: [PATCH] perf record: Conditionally define CLOCK_MONOTONIC_RAW for older OSes Message-ID: <20150408085519.GV23123@twins.programming.kicks-ass.net> References: <1428465748-14476-1-git-send-email-yunlong.song@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1428465748-14476-1-git-send-email-yunlong.song@huawei.com> User-Agent: Mutt/1.5.21 (2012-12-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 917 Lines: 20 On Wed, Apr 08, 2015 at 12:02:28PM +0800, Yunlong Song wrote: > Commit 31a9883106cc ("perf record: Add clockid parameter") used > CLOCK_MONOTONIC_RAW in the struct clockid_map clockids[], but the > CLOCK_MONOTONIC_RAW macro is not defined in older releases (e.g., SLES > 11 SP2), thus there is a building error when making perf: > > builtin-record.c:738: error: ‘CLOCK_MONOTONIC_RAW’ undeclared here (not in a function) Weird that, CLOCK_MONOTONIC_RAW is said to be in the kernel since 2.6.28, SLES11 SP2 is 3.0 based, SP1 is 2.6.32. Now the original SLES11 started life with 2.6.27, so it looks like someone forgot to update their kernel headers when upgrading. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/