Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753551AbbDHJo4 (ORCPT ); Wed, 8 Apr 2015 05:44:56 -0400 Received: from mail-ie0-f175.google.com ([209.85.223.175]:34588 "EHLO mail-ie0-f175.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751770AbbDHJox convert rfc822-to-8bit (ORCPT ); Wed, 8 Apr 2015 05:44:53 -0400 MIME-Version: 1.0 In-Reply-To: <20150408113003.78ec5f86@amdc2363> References: <1427387955-5129-1-git-send-email-linux.amoon@gmail.com> <1427387955-5129-4-git-send-email-linux.amoon@gmail.com> <20150408100240.7f597dae@amdc2363> <20150408113003.78ec5f86@amdc2363> Date: Wed, 8 Apr 2015 15:14:52 +0530 Message-ID: Subject: Re: [PATCH 3/6] ARM:dts exynos5422 Update the thermal sensor for tmu_cpu0 From: Anand Moon To: Lukasz Majewski Cc: devicetree@vger.kernel.org, "linux-samsung-soc@vger.kernel.org" , Russell King , linux-pwm@vger.kernel.org, linux-kernel@vger.kernel.org, Eduardo Valentin , Sjoerd Simons , Kukjin Kim , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 7865 Lines: 215 Hi Lukasz, I have Odroidxu3 board with fan. Odroid xu3 board and run on high temperature. As per my understating as the sensors temperature cross the first alert it triggers fan to run. I was doing some stress testing to trigger this overheating with my changes. -Anand Moon On 8 April 2015 at 15:00, Lukasz Majewski wrote: > Hi Anand, > >> Hi Lukasz, >> >> On Odroidxu3 board critical temp is 85.0 C. Below is the sensors >> output. > > Do you have XU3 with a fan? > >> >> therm_zone0-virtual-0 >> Adapter: Virtual device >> temp1: +39.0▒ၰC (crit = +85.0▒°C) >> temp2: +38.0▒°C (crit = +85.0▒°C) >> temp3: +40.0▒°C (crit = +85.0▒°C) >> temp4: +49.0▒°C (crit = +85.0▒°C) >> temp5: +29.0▒°C (crit = +85.0▒°C) >> >> I have observed cpu shutdown as we do test pm-qa thermal testing. >> >> So I propose the temperature values to be 50000, 65000 ,80000 and >> 85000 Critical temperature. >> > > This seems strange - since other Samsung's SoC have higher work > temperatures (both exynos5 and exynos4). > > I will try to check those thresholds on my XU3. Have anybody else > experienced overheating at XU3? > > Sjoerd? Kukjin? > >> Please share your thoughts. >> >> -Anand Moon >> >> On 8 April 2015 at 13:32, Lukasz Majewski >> wrote: >> > Hi Anand, >> > >> >> Move the registration of thermal sensors for tmu_cpu0 from >> >> exynos5420.dtsi to exynos5-cpu-thermal.dtsi, to avoid duplicate >> >> registration of the sensors. >> >> >> >> Tested on OdroidXU3 board. >> >> >> >> Signed-off-by: Anand Moon >> >> --- >> >> arch/arm/boot/dts/exynos5-cpu-thermal.dtsi | 58 >> >> ++++++++++++++++++++++++++++++ >> >> arch/arm/boot/dts/exynos5420.dtsi | 4 --- >> >> arch/arm/boot/dts/exynos5422-odroidxu3.dts | 1 + 3 files changed, >> >> 59 insertions(+), 4 deletions(-) create mode 100644 >> >> arch/arm/boot/dts/exynos5-cpu-thermal.dtsi >> >> >> >> diff --git a/arch/arm/boot/dts/exynos5-cpu-thermal.dtsi >> >> b/arch/arm/boot/dts/exynos5-cpu-thermal.dtsi new file mode 100644 >> >> index 0000000..8fede70 >> >> --- /dev/null >> >> +++ b/arch/arm/boot/dts/exynos5-cpu-thermal.dtsi >> >> @@ -0,0 +1,58 @@ >> >> +/* >> >> + * Device tree sources for Exynos5 thermal zone >> >> + * >> >> + * Copyright (c) 2014 Lukasz Majewski >> > >> > ^^^^^^^^^^^^^^^^ Could you update this >> > line :-). I'm just reviewer here :-) >> > >> >> + * >> >> + * This program is free software; you can redistribute it and/or >> >> modify >> >> + * it under the terms of the GNU General Public License version 2 >> >> as >> >> + * published by the Free Software Foundation. >> >> + * >> >> + */ >> >> + >> >> +#include >> >> + >> >> +/ { >> >> + thermal-zones { >> >> + cpu0_thermal: cpu0-thermal { >> >> + thermal-sensors = <&tmu_cpu0>; >> >> + polling-delay-passive = <0>; >> >> + polling-delay = <0>; >> >> + trips { >> >> + cpu_alert0: cpu-alert-0 { >> >> + temperature = <48000>; /* ms >> >> */ >> >> + hysteresis = <3000>; /* ms */ >> > ^^^^^^^^^ >> > We already >> > have "millicelsius" >> > instead od >> > ms >> >> + type = "active"; >> >> + }; >> >> + cpu_alert1: cpu-alert-1 { >> >> + temperature = <53000>; /* ms >> >> */ >> >> + hysteresis = <3000>; /* ms */ >> >> + type = "active"; >> >> + }; >> >> + cpu_alert2: cpu-alert-2 { >> >> + temperature = <59000>; /* ms >> >> */ >> >> + hysteresis = <3000>; /* ms */ >> >> + type = "active"; >> >> + }; >> >> + cpu_crit0: cpu-crit-0 { >> >> + temperature = <75000>; /* ms >> >> */ >> >> + hysteresis = <0>; /* ms */ >> >> + type = "critical"; >> > >> > Is there any special reasons why we need special >> > values for cpu0_thermal sensor at XU3? Is something wrong with >> > default values defined at exynos4-cpu-thermal.dtsi? >> > >> > If this is Odroid XU3 specific, then IMHO it should >> > be added to exynos5422-odroidxu3.dts >> > >> >> + }; >> >> + }; >> >> + cooling-maps { >> >> + map0 { >> >> + trip = <&cpu_alert0>; >> >> + cooling-device = <&fan0 0 1>; >> >> + }; >> >> + map1 { >> >> + trip = <&cpu_alert1>; >> >> + cooling-device = <&fan0 1 2>; >> >> + }; >> >> + map2 { >> >> + trip = <&cpu_alert2>; >> >> + cooling-device = <&fan0 2 3>; >> >> + }; >> >> + }; >> >> + }; >> >> + }; >> >> +}; >> >> diff --git a/arch/arm/boot/dts/exynos5420.dtsi >> >> b/arch/arm/boot/dts/exynos5420.dtsi index 6b49f3c..eb0f16c 100644 >> >> --- a/arch/arm/boot/dts/exynos5420.dtsi >> >> +++ b/arch/arm/boot/dts/exynos5420.dtsi >> >> @@ -827,10 +827,6 @@ >> >> }; >> >> >> >> thermal-zones { >> >> - cpu0_thermal: cpu0-thermal { >> >> - thermal-sensors = <&tmu_cpu0>; >> >> - #include "exynos5420-trip-points.dtsi" >> > ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [1] >> > >> >> - }; >> >> cpu1_thermal: cpu1-thermal { >> >> thermal-sensors = <&tmu_cpu1>; >> >> #include "exynos5420-trip-points.dtsi" >> >> diff --git a/arch/arm/boot/dts/exynos5422-odroidxu3.dts >> >> b/arch/arm/boot/dts/exynos5422-odroidxu3.dts index eaec006..c8b3e3e >> >> 100644 --- a/arch/arm/boot/dts/exynos5422-odroidxu3.dts >> >> +++ b/arch/arm/boot/dts/exynos5422-odroidxu3.dts >> >> @@ -12,6 +12,7 @@ >> >> >> >> /dts-v1/; >> >> #include "exynos5800.dtsi" >> >> +#include "exynos5-cpu-thermal.dtsi" >> > >> > I would prefer to stick to convention proposed at [1]. It keeps >> > the locality of the include with respective thermal zone. >> > >> >> >> >> / { >> >> model = "Hardkernel Odroid XU3"; >> > >> > DTS changes should be added to Samsung tree by Samsung maintainer - >> > Mr. Kukjin Kim. >> > >> > -- >> > Best regards, >> > >> > Lukasz Majewski >> > >> > Samsung R&D Institute Poland (SRPOL) | Linux Platform Group >> >> _______________________________________________ >> linux-arm-kernel mailing list >> linux-arm-kernel@lists.infradead.org >> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel > > > > -- > Best regards, > > Lukasz Majewski > > Samsung R&D Institute Poland (SRPOL) | Linux Platform Group -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/