Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753708AbbDHMGu (ORCPT ); Wed, 8 Apr 2015 08:06:50 -0400 Received: from eusmtp01.atmel.com ([212.144.249.242]:59158 "EHLO eusmtp01.atmel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753318AbbDHMGs (ORCPT ); Wed, 8 Apr 2015 08:06:48 -0400 Message-ID: <552519B7.2090206@atmel.com> Date: Wed, 8 Apr 2015 14:06:15 +0200 From: Nicolas Ferre Organization: atmel User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 MIME-Version: 1.0 To: Bartlomiej Zolnierkiewicz , Alexandre Belloni CC: , Boris Brezillon , , , , Tejun Heo , Jean-Christophe Plagniol-Villard Subject: Re: [PATCH v2 1/9] ata: at91: use syscon to configure the smc References: <1427138955-3617-1-git-send-email-alexandre.belloni@free-electrons.com> <2936706.hVbBP0ExQQ@amdc1032> <20150408111335.GZ20669@piout.net> <3156869.zFaIKVVpHK@amdc1032> In-Reply-To: <3156869.zFaIKVVpHK@amdc1032> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 8bit X-Originating-IP: [10.161.30.18] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2386 Lines: 57 Le 08/04/2015 14:00, Bartlomiej Zolnierkiewicz a ?crit : > On Wednesday, April 08, 2015 01:13:35 PM Alexandre Belloni wrote: >> Hi, >> >> On 08/04/2015 at 13:04:19 +0200, Bartlomiej Zolnierkiewicz wrote : >>> On Monday, March 23, 2015 08:29:07 PM Alexandre Belloni wrote: >>>> Use syscon/regmap to configure the smc. This allows to avoid using >>>> at91sam9_smc.h and to compile the driver in a multiplatform configuration. >>>> >>>> The driver will still not probe until the proper DT bindings are added. That >>>> binding will include an atmel,smc property that is a phandle to the SMC the CF >>>> controller is connected to. >>> >>> If the driver is currently working fine in !ARCH_MULTIPLATFORM >>> configuration then this patch will make it non-functional until >>> atmel,smc property is added to DT. To prevent this and preserve >>> bisectability the patchset should first add atmel,smc property >>> and then convert pata_at91 driver to use it. >>> >> >> Starting with 4.1, it will not be possible to use the driver anyway as >> all the platforms using it have switched to multiplatform. This patch >> makes it compilable again. > > Hmm. It seems that it was your commit which did the switch without > converting all at91 specific code to be multiplatform ready first: > > From: Alexandre Belloni > Date: Fri, 13 Mar 2015 22:57:18 +0100 > Subject: ARM: at91: switch to multiplatform > > Switch AT91 to multiplatform as all SoCs are properly handled. > > Signed-off-by: Alexandre Belloni > Signed-off-by: Nicolas Ferre > > ? > >> Anyway, it seems that there is little interest in that driver and nobody >> I contacted has access to a board which can be used to test this. > > If there are no users then probably the driver can be removed but this > something that platform Maintainers should decide on. This is why there are loose constrains on this driver and that we decided to move on. So I think that modifying it and introducing the DT property afterwards can be done. Bye, -- Nicolas Ferre -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/