Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754044AbbDHNMG (ORCPT ); Wed, 8 Apr 2015 09:12:06 -0400 Received: from bh-25.webhostbox.net ([208.91.199.152]:33288 "EHLO bh-25.webhostbox.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752922AbbDHNMD (ORCPT ); Wed, 8 Apr 2015 09:12:03 -0400 Message-ID: <55252905.1020708@roeck-us.net> Date: Wed, 08 Apr 2015 06:11:33 -0700 From: Guenter Roeck User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 MIME-Version: 1.0 To: Lukasz Majewski , Anand Moon CC: Eduardo Valentin , Sjoerd Simons , Russell King , Kukjin Kim , devicetree@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-pwm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH 6/6] hwmon: pwm-fan: Update the duty cycle inorder to control the pwm-fan References: <1427387955-5129-1-git-send-email-linux.amoon@gmail.com> <1427387955-5129-7-git-send-email-linux.amoon@gmail.com> <20150408104415.07e1c821@amdc2363> In-Reply-To: <20150408104415.07e1c821@amdc2363> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-Authenticated_sender: linux@roeck-us.net X-OutGoing-Spam-Status: No, score=-1.0 X-CTCH-PVer: 0000001 X-CTCH-Spam: Unknown X-CTCH-VOD: Unknown X-CTCH-Flags: 0 X-CTCH-RefID: str=0001.0A020206.55252922.009C,ss=1,re=0.001,recu=0.000,reip=0.000,cl=1,cld=1,fgs=0 X-CTCH-Score: 0.001 X-CTCH-ScoreCust: 0.000 X-CTCH-Rules: C_4847, X-CTCH-SenderID: linux@roeck-us.net X-CTCH-SenderID-Flags: 0 X-CTCH-SenderID-TotalMessages: 8 X-CTCH-SenderID-TotalSpam: 0 X-CTCH-SenderID-TotalSuspected: 0 X-CTCH-SenderID-TotalConfirmed: 0 X-CTCH-SenderID-TotalBulk: 0 X-CTCH-SenderID-TotalVirus: 0 X-CTCH-SenderID-TotalRecipients: 0 X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - bh-25.webhostbox.net X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - roeck-us.net X-Get-Message-Sender-Via: bh-25.webhostbox.net: mailgid no entry from get_relayhosts_entry X-Source: X-Source-Args: X-Source-Dir: Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1770 Lines: 65 On 04/08/2015 01:44 AM, Lukasz Majewski wrote: > Hi Anand, > >> Below changes depend on following patch. >> https://patchwork.kernel.org/patch/5944061/ >> >> Update the pwm_config with duty then update the pwm_disable >> to poweroff the cpu fan. >> >> Tested on OdroidXU3 board. >> >> Signed-off-by: Anand Moon >> --- >> drivers/hwmon/pwm-fan.c | 10 ++++------ >> 1 file changed, 4 insertions(+), 6 deletions(-) >> >> diff --git a/drivers/hwmon/pwm-fan.c b/drivers/hwmon/pwm-fan.c >> index 7c83dc4..f25c841 100644 >> --- a/drivers/hwmon/pwm-fan.c >> +++ b/drivers/hwmon/pwm-fan.c >> @@ -44,26 +44,24 @@ static int __set_pwm(struct pwm_fan_ctx *ctx, >> unsigned long pwm) int ret = 0; >> >> mutex_lock(&ctx->lock); >> + >> if (ctx->pwm_value == pwm) >> goto exit_set_pwm_err; >> >> - if (pwm == 0) { >> - pwm_disable(ctx->pwm); >> - goto exit_set_pwm; >> - } >> - >> duty = DIV_ROUND_UP(pwm * (ctx->pwm->period - 1), MAX_PWM); >> ret = pwm_config(ctx->pwm, duty, ctx->pwm->period); >> if (ret) >> goto exit_set_pwm_err; >> >> + if (pwm == 0) >> + pwm_disable(ctx->pwm); >> + >> if (ctx->pwm_value == 0) { >> ret = pwm_enable(ctx->pwm); >> if (ret) >> goto exit_set_pwm_err; >> } >> >> -exit_set_pwm: >> ctx->pwm_value = pwm; >> exit_set_pwm_err: >> mutex_unlock(&ctx->lock); > > Reviewed-by: Lukasz Majewski > > BTW: I've added Guenter to CC. > I don't have a copy of the original patch, so I can't apply it. Guenter -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/