Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932442AbbDHOnf (ORCPT ); Wed, 8 Apr 2015 10:43:35 -0400 Received: from mail-ie0-f182.google.com ([209.85.223.182]:33804 "EHLO mail-ie0-f182.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932174AbbDHOna (ORCPT ); Wed, 8 Apr 2015 10:43:30 -0400 MIME-Version: 1.0 In-Reply-To: <1428403425-12058-1-git-send-email-ckeepax@opensource.wolfsonmicro.com> References: <1428403425-12058-1-git-send-email-ckeepax@opensource.wolfsonmicro.com> Date: Wed, 8 Apr 2015 16:43:30 +0200 Message-ID: Subject: Re: [PATCH] pinctrl: bcm2835: Fix support for threaded level triggered IRQs From: Linus Walleij To: Charles Keepax , Ray Jui , Stephen Warren Cc: Lee Jones , "linux-gpio@vger.kernel.org" , linux-rpi-kernel@lists.infradead.org, "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 918 Lines: 22 On Tue, Apr 7, 2015 at 12:43 PM, Charles Keepax wrote: > Currently, the driver uses handle_simple_irq for all IRQ types and hard > codes the acknowledge for different IRQ types into the handler. It is > better to use the IRQ core as intended and let it handle the differences > between the various types of IRQ. For example the current system does > not work for threaded level triggered IRQs as these need to be masked > until the threaded handler has run. > > Signed-off-by: Charles Keepax Looks like a very fine patch so applied unless Stephen has some problem with it. Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/