Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754387AbbDHPal (ORCPT ); Wed, 8 Apr 2015 11:30:41 -0400 Received: from mga03.intel.com ([134.134.136.65]:51802 "EHLO mga03.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753732AbbDHPai (ORCPT ); Wed, 8 Apr 2015 11:30:38 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.11,545,1422950400"; d="scan'208";a="552934236" Date: Wed, 8 Apr 2015 18:30:34 +0300 From: Vlad Dogaru To: Irina Tirdea Cc: Jonathan Cameron , linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, Hartmut Knaack Subject: Re: [PATCH] iio: pressure: bmp280: fix temp compensation Message-ID: <20150408153034.GA23781@vdogaru> References: <1428506772-23710-1-git-send-email-irina.tirdea@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1428506772-23710-1-git-send-email-irina.tirdea@intel.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 720 Lines: 21 On Wed, Apr 08, 2015 at 06:26:12PM +0300, Irina Tirdea wrote: > Temperature reads on bmp280 device always return 0, > due to a missing step in the compensation formula > (data->tfine is never initialized). > > Initialize data->tfine value so we get correct > temperature and pressure values. > > Signed-off-by: Irina Tirdea Reviewed-by: Vlad Dogaru Nice catch, this must have been lost during a refactoring. Thanks, Vlad -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/