Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932253AbbDHQ0T (ORCPT ); Wed, 8 Apr 2015 12:26:19 -0400 Received: from mail-qg0-f42.google.com ([209.85.192.42]:34551 "EHLO mail-qg0-f42.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932209AbbDHQ0Q (ORCPT ); Wed, 8 Apr 2015 12:26:16 -0400 Message-ID: <552556A5.5070204@hurleysoftware.com> Date: Wed, 08 Apr 2015 12:26:13 -0400 From: Peter Hurley User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 MIME-Version: 1.0 To: Linus Torvalds CC: Vinod Koul , Felipe Balbi , Maxime Ripard , Laurent Pinchart , Linux kernel Subject: Re: [4.0-rc+] WARNING: CPU: 0 PID: 1 at ./drivers/dma/dmaengine.c:863 dma_async_device_register+0xe0/0x540() References: <54F87075.5020105@hurleysoftware.com> <20150305161236.GG2613@intel.com> <55254EFD.10700@hurleysoftware.com> In-Reply-To: <55254EFD.10700@hurleysoftware.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 5671 Lines: 100 Linus, I just got an automated bounce reply from Vinod Koul stating he's on vacation til April 12th, so I'd appreciate if you could revert this commit [1] for 4.0-final. The commit generates a WARNING [2] in a effort to get dmaengine drivers to add new functionality. I sent Vinod a note that this was happening on Beaglebone Blacks back on Mar 5 (-rc3). He thought the functionality would be added shortly, but it wasn't, so the WARNING is still happening on -rc7. Regards, Peter Hurley On 04/08/2015 11:53 AM, Peter Hurley wrote: > On 03/05/2015 11:12 AM, Vinod Koul wrote: >> On Thu, Mar 05, 2015 at 10:04:21AM -0500, Peter Hurley wrote: >>>> First boot of 4.0-rc+ gave me [1] on a Beaglebone Black due to >>>> >> The warning is intentional to get driver fixed and give the right behaviour >> >> Felipe had sent a patch for this but that one needs an update > > Vinod, > > Felipe's patch never made it to mainline, and this warning is > still happening on 4.0-rc7 so please revert for 4.0-final. > > Regards, > Peter Hurley > > >> -- ~Vinod [1] >>>> commit ecc19d17868be9c9f8f00ed928791533c420f3e0 >>>> Author: Maxime Ripard >>>> Date: Mon Nov 17 14:42:53 2014 +0100 >>>> >>>> dmaengine: Add a warning for drivers not using the generic slave caps retrieval >>>> >>>> For the slave caps retrieval to be really useful, most drivers need to >>>> implement it. >>>> >>>> Hence, we need to be slightly more aggressive, and trigger a warning at >>>> registration time for drivers that don't fill their caps infos in order to >>>> encourage them to implement it. >>>> >>>> Signed-off-by: Maxime Ripard >>>> Acked-by: Laurent Pinchart >>>> Signed-off-by: Vinod Koul [2] >>>> [ 1.848374] WARNING: CPU: 0 PID: 1 at /home/peter/src/kernels/mainline/drivers/dma/dmaengine.c:863 dma_async_device_register+0xe0/0x540() >>>> [ 1.860798] this driver doesn't support generic slave capabilities reporting >>>> [ 1.867893] Modules linked in: >>>> [ 1.870993] CPU: 0 PID: 1 Comm: swapper Not tainted 4.0.0-rc2+ #115 >>>> [ 1.877302] Hardware name: Generic AM33XX (Flattened Device Tree) >>>> [ 1.883478] [] (unwind_backtrace) from [] (show_stack+0x20/0x24) >>>> [ 1.891307] [] (show_stack) from [] (dump_stack+0x24/0x28) >>>> [ 1.898602] [] (dump_stack) from [] (warn_slowpath_common+0x94/0xc0) >>>> [ 1.906753] [] (warn_slowpath_common) from [] (warn_slowpath_fmt+0x40/0x48) >>>> [ 1.915515] [] (warn_slowpath_fmt) from [] (dma_async_device_register+0xe0/0x540) >>>> [ 1.924806] [] (dma_async_device_register) from [] (cppi41_dma_probe+0x470/0x4c0) >>>> [ 1.934397] [] (cppi41_dma_probe) from [] (platform_drv_probe+0x54/0xb4) >>>> [ 1.942924] [] (platform_drv_probe) from [] (driver_probe_device+0x14c/0x3a8) >>>> [ 1.951861] [] (driver_probe_device) from [] (__device_attach+0x50/0x54) >>>> [ 1.960360] [] (__device_attach) from [] (bus_for_each_drv+0x68/0x9c) >>>> [ 1.968596] [] (bus_for_each_drv) from [] (device_attach+0x84/0x98) >>>> [ 1.976656] [] (device_attach) from [] (bus_probe_device+0x94/0xb8) >>>> [ 1.984717] [] (bus_probe_device) from [] (device_add+0x3dc/0x59c) >>>> [ 1.992700] [] (device_add) from [] (of_device_add+0x44/0x4c) >>>> [ 2.000242] [] (of_device_add) from [] (of_platform_device_create_pdata+0x140/0x234) >>>> [ 2.009788] [] (of_platform_device_create_pdata) from [] (of_platform_bus_create+0x10c/0x234) >>>> [ 2.020118] [] (of_platform_bus_create) from [] (of_platform_populate+0x6c/0xc8) >>>> [ 2.029319] [] (of_platform_populate) from [] (am335x_child_probe+0x38/0x54) >>>> [ 2.038168] [] (am335x_child_probe) from [] (platform_drv_probe+0x54/0xb4) >>>> [ 2.046840] [] (platform_drv_probe) from [] (driver_probe_device+0x14c/0x3a8) >>>> [ 2.055774] [] (driver_probe_device) from [] (__driver_attach+0x9c/0xa0) >>>> [ 2.064268] [] (__driver_attach) from [] (bus_for_each_dev+0x70/0xa4) >>>> [ 2.072501] [] (bus_for_each_dev) from [] (driver_attach+0x2c/0x30) >>>> [ 2.080561] [] (driver_attach) from [] (bus_add_driver+0x170/0x22c) >>>> [ 2.088623] [] (bus_add_driver) from [] (driver_register+0x88/0x108) >>>> [ 2.096770] [] (driver_register) from [] (__platform_driver_register+0x64/0x6c) >>>> [ 2.105884] [] (__platform_driver_register) from [] (am335x_child_init+0x1c/0x20) >>>> [ 2.115171] [] (am335x_child_init) from [] (do_one_initcall+0xe8/0x230) >>>> [ 2.123592] [] (do_one_initcall) from [] (kernel_init_freeable+0x1e0/0x284) >>>> [ 2.132355] [] (kernel_init_freeable) from [] (kernel_init+0x1c/0x100) >>>> [ 2.140681] [] (kernel_init) from [] (ret_from_fork+0x14/0x24) -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/