Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932164AbbDHTxs (ORCPT ); Wed, 8 Apr 2015 15:53:48 -0400 Received: from mezzanine.sirena.org.uk ([106.187.55.193]:57445 "EHLO mezzanine.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753439AbbDHTxp (ORCPT ); Wed, 8 Apr 2015 15:53:45 -0400 Date: Wed, 8 Apr 2015 20:53:33 +0100 From: Mark Brown To: Jonathan Richardson Cc: Dmitry Torokhov , Anatol Pomazau , Scott Branden , Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , linux-kernel@vger.kernel.org, linux-spi@vger.kernel.org, bcm-kernel-feedback-list , devicetree@vger.kernel.org, Rafal Milecki Message-ID: <20150408195333.GL6023@sirena.org.uk> References: <1428516275-12819-1-git-send-email-jonathar@broadcom.com> <1428516275-12819-6-git-send-email-jonathar@broadcom.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="vBRHxyNZEr4ELWc5" Content-Disposition: inline In-Reply-To: <1428516275-12819-6-git-send-email-jonathar@broadcom.com> X-Cookie: I've been there. User-Agent: Mutt/1.5.23 (2014-03-12) X-SA-Exim-Connect-IP: 94.175.94.161 X-SA-Exim-Mail-From: broonie@sirena.org.uk Subject: Re: [PATCH v2 5/5] spi: bcm-mspi: Add support to set serial baud clock rate X-SA-Exim-Version: 4.2.1 (built Mon, 26 Dec 2011 16:24:06 +0000) X-SA-Exim-Scanned: Yes (on mezzanine.sirena.org.uk) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1654 Lines: 44 --vBRHxyNZEr4ELWc5 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Wed, Apr 08, 2015 at 11:04:35AM -0700, Jonathan Richardson wrote: > + /* > + * Enable clock if provided. The frequency can be changed by setting > + * SPBR (serial clock baud rate) based on the desired 'clock-frequency'. > + * > + * Baud rate is calculated as: mspi_clk / (2 * SPBR) where SPBR is a > + * value between 1-255. If not set then it is left at the h/w default. > + */ > + data->clk = devm_clk_get(dev, "mspi_clk"); > + if (!IS_ERR(data->clk)) { This is adding things to the DT binding, any new binding or binding changes need to be documented. It should also be paying attention to errors rather than silently ignoring them, at least -EPROBE_DEFER should be handled properly. --vBRHxyNZEr4ELWc5 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEbBAEBCAAGBQJVJYc8AAoJECTWi3JdVIfQ2J8H92B53JZia2zuMVX3pbCe2yBV nO8cikzfycqE1o4hhye0h7NOn8yNOqloETeKBXiDEm1LwYkiMC1vR7RYEXJdX4pS n7WxYgdz+FNMgU7keMKwhoGw003FK1KSty/iIDLsAdr+/LDCzGktJfVZnbJula8/ DDlj5PYqrF8BlEFpoTFyRVVCMmkonytENNkDIQxCqyL0I63POp2Rj7IvL+oVqRp9 F7BmYNB3zBCm0GtjYXvuctgB9or1Vb9ZFbBMTFzxY6iscn3ykuk4alx7Qe9cbF/C kSSUcC5c65HTK+HkaMfSQS4UD4197KyHhbLCTYv/rIrP+lPMQRQhqGTZuHeFCQ== =GO8V -----END PGP SIGNATURE----- --vBRHxyNZEr4ELWc5-- -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/