Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753991AbbDHUDZ (ORCPT ); Wed, 8 Apr 2015 16:03:25 -0400 Received: from mezzanine.sirena.org.uk ([106.187.55.193]:57464 "EHLO mezzanine.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753200AbbDHUDW (ORCPT ); Wed, 8 Apr 2015 16:03:22 -0400 Date: Wed, 8 Apr 2015 21:03:06 +0100 From: Mark Brown To: Jonathan Richardson Cc: Dmitry Torokhov , Anatol Pomazau , Scott Branden , Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , linux-kernel@vger.kernel.org, linux-spi@vger.kernel.org, bcm-kernel-feedback-list , devicetree@vger.kernel.org, Rafal Milecki Message-ID: <20150408200306.GM6023@sirena.org.uk> References: <1428516275-12819-1-git-send-email-jonathar@broadcom.com> <1428516275-12819-5-git-send-email-jonathar@broadcom.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="yfgt5/gpfXq9ryTU" Content-Disposition: inline In-Reply-To: <1428516275-12819-5-git-send-email-jonathar@broadcom.com> X-Cookie: I've been there. User-Agent: Mutt/1.5.23 (2014-03-12) X-SA-Exim-Connect-IP: 94.175.94.161 X-SA-Exim-Mail-From: broonie@sirena.org.uk Subject: Re: [PATCH v2 4/5] spi: bcm-mspi: Make BCMA optional to support non-BCMA chips X-SA-Exim-Version: 4.2.1 (built Mon, 26 Dec 2011 16:24:06 +0000) X-SA-Exim-Scanned: Yes (on mezzanine.sirena.org.uk) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1787 Lines: 44 --yfgt5/gpfXq9ryTU Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Wed, Apr 08, 2015 at 11:04:34AM -0700, Jonathan Richardson wrote: > - A new config for non-BCMA chips has been added. > - Common code between the BCMA and non BCMA version are shared. > - Function pointers to set read/write functions to abstract bcma > and non-bcma versions are provided. > - DT is now mandatory. Hard coded SPI devices are removed and must be > set in DT. > - Remove function was unnecessary and removed. This looks like it should be a patch series in itself - for example, the move to using function pointers as a read/write operation looks like something that could easily be pulled out, as could the removal of unused functions. Having things split out makes life a lot easier for review since it makes it much easier to check if the change is doing the things it's supposed to be doing. --yfgt5/gpfXq9ryTU Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBCAAGBQJVJYl5AAoJECTWi3JdVIfQdfcH/0hJB2TpIJARWa1y8Yny0t6O gPvmpMQZxAKi0gMzP9R+9A0RaIJ3KmAlDXu/wC5saOfYPQQQDC1wOWqtDL4WWJRQ 8q/yJSGpaknD1Y2OVpxLfEZhsYxU6JSl427czMVKOas9ES6AIzbFLfPLWNRU6cLS +LM7UtX9jzPMJRokh2p3b5R+pMSFtc9A++icBACtIiT7ZErhNW4vos66xpo3JarK H75pHl+vPQcGE7BPrv7bnZIGubCc8nPBXiP9wPlotr607M2q09d8NVFoUl6YDNIO 6wSyoiGIpRif2MoMcNLTl2QAA2bVtBnOIIaUMk72ebH4NbZYC/NybRmQ8UUGxNo= =hrkq -----END PGP SIGNATURE----- --yfgt5/gpfXq9ryTU-- -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/